Skip to content

PHOENIX-6509 PHOENIX-4424 Allow users to create DEFAULT and HBASE Schema (Uppercase Schema Names) - #1263

Merged
virajjasani merged 1 commit into
apache:masterfrom
shahrs87:PHOENIX-6509
Jul 10, 2021
Merged

PHOENIX-6509 PHOENIX-4424 Allow users to create DEFAULT and HBASE Schema (Uppercase Schema Names)#1263
virajjasani merged 1 commit into
apache:masterfrom
shahrs87:PHOENIX-6509

Conversation

@shahrs87

Copy link
Copy Markdown
Contributor

Almost a clean cherry pick of PHOENIX-4424
c075a17

@shahrs87

Copy link
Copy Markdown
ContributorAuthor

Cc @virajjasani

@stoty

stoty commented Jul 9, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 50sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall23m 24smaster passed
+0hbaserecompile30m 3sHBase recompiled.
+1 💚compile1m 1smaster passed
+1 💚checkstyle2m 12smaster passed
+1 💚javadoc0m 52smaster passed
+0 🆗spotbugs3m 7sphoenix-core in master has 965 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall13m 41sthe patch passed
+0hbaserecompile24m 10sHBase recompiled.
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
-1 ❌checkstyle2m 16sphoenix-core: The patch generated 7 new + 3990 unchanged - 8 fixed = 3997 total (was 3998)
-1 ❌whitespace0m 0sThe patch 1 line(s) with tabs.
+1 💚javadoc0m 49sthe patch passed
+1 💚spotbugs3m 15sthe patch passed
_ Other Tests _
-1 ❌unit113m 10sphoenix-core in the patch failed.
+1 💚asflicense0m 46sThe patch does not generate ASF License warnings.
187m 35s
ReasonTests
Failed junit testsphoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1263
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 6fd8097a199d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 62f63c8
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
whitespacehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/whitespace-tabs.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/testReport/
Max. process+thread count14242 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani
virajjasani merged commit a1044c9 into apache:masterJul 10, 2021
virajjasani pushed a commit that referenced this pull request Jul 10, 2021
…ema (Uppercase Schema Names) (#1263)
Signed-off-by: Viraj Jasani <vjasani@apache.org>
@shahrs87

Copy link
Copy Markdown
ContributorAuthor

Thank you @virajjasani for the review and commit !

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@shahrs87@stoty@virajjasani