PHOENIX-6510 Double-Checked Locking field must be volatile

[jojochuang]

No description provided.

[gjacoby126]

+1 assuming tests pass

[jojochuang]

Something is wrong with the Jenkins. I tried to trigger the precommit job again but it failed outright immediately: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/2/console

java.nio.file.FileSystemException: /home/jenkins/jenkins-home/workspace/enix-PreCommit-GitHub-PR_PR-1264: Read-only file system

[stoty]

I wonder if switching to eager initialization (at least in PhoenixConnection.java ) would be a more performant option.

Looking at ConcurrentLinkedQueue, it seems to be cheap to initalize, and we could simplify the code as well.

[jojochuang]

Yeah this lazy initialization in PhoenixConnection isn't used correctly anyway.
removeChildConnection() isn't thread safe.

Let's change it. Do you want it to be in a separate PR or are you okay to have it in the same one?

[stoty]

Fine in this one.

[stoty]

+1 LGTM

I'll wait for the Jenkins job to finish before merging. (If I forget it, ping me pls)

[stoty]

Jenkins is still down, it seems.

[jojochuang]

I asked Infra to investigate INFRA-22106 and looks like it'll take a while for the hardware to reset.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	28m 40s	master passed
+0	hbaserecompile	37m 37s	HBase recompiled.
+1 💚	compile	1m 19s	master passed
+1 💚	checkstyle	0m 52s	master passed
+1 💚	javadoc	1m 3s	master passed
+0 🆗	spotbugs	4m 10s	phoenix-core in master has 964 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	19m 18s	the patch passed
+0	hbaserecompile	32m 12s	HBase recompiled.
+1 💚	compile	1m 20s	the patch passed
+1 💚	javac	1m 20s	the patch passed
-1 ❌	checkstyle	0m 52s	phoenix-core: The patch generated 5 new + 507 unchanged - 8 fixed = 512 total (was 515)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	1m 2s	the patch passed
+1 💚	spotbugs	4m 28s	phoenix-core generated 0 new + 960 unchanged - 4 fixed = 960 total (was 964)
		_ Other Tests _
-1 ❌	unit	117m 56s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 42s	The patch does not generate ASF License warnings.
		203m 58s

Reason	Tests
Failed junit tests	phoenix.end2end.LogicalTableNameIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1264
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname	Linux ea075d658a16 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 9c9dd0b
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/6/testReport/
Max. process+thread count	14521 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1264/6/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[jojochuang]

Thanks!