Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6405 Disallow bulk loading into non-empty tables with global … - #1265
Merged
Conversation
stoty
reviewed
Jul 13, 2021
| // There must be a better solution for this | ||
| String tn = sName == null ? "\"" + tName + "\"" : "\"" + sName + "\".\"" + tName + "\""; | ||
| ResultSet rsempty = conn.createStatement().executeQuery("SELECT * FROM " + tn); |
Contributor
There was a problem hiding this comment.
Add limit 1 to hopefully reduce the load.
Contributor
There was a problem hiding this comment.
Also I'm sure we already have a utility function somewhere to generate the table name from the components.
stoty
reviewed
Jul 14, 2021
| List<TargetTableRef> tablesToBeLoaded = new ArrayList<TargetTableRef>(); | ||
| PTable table = PhoenixRuntime.getTable(conn, qualifiedTableName); | ||
| boolean isImmutable = table.isImmutableRows(); |
Contributor
There was a problem hiding this comment.
I think that bulk loading does not observe immutability, and you can modify rows with it.
If that's true, then we shouldn't treat immuable tables any different than normal ones.
Could you please check this ?
stoty
commented
Jul 15, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
suggested changes
Jul 15, 2021
| String sName = SchemaUtil.normalizeIdentifier(schemaName); | ||
| String tName = SchemaUtil.normalizeIdentifier(tableName); | ||
| // There must be a better solution for this |
Contributor
There was a problem hiding this comment.
nit:
I don't think there really is.
We could query the table via HBase API directly, but that wouldn't really help.
| } | ||
| if(hasGlobalIndexes && tableNotEmpty && !cmdLine.hasOption(ENABLE_CORRUPT_INDEXES.getOpt())){ | ||
| throw new IllegalStateException("Bulk Loader error: Bulk loading is disabled for" + |
Contributor
There was a problem hiding this comment.
A bit more context may help:
Bulk Loading error: Bulk loading is disabled for non empty tables with global indexes, because it will corrupt the global index table in most cases.
Use the --corruptindexes option to override this check.
…secondary indexes Change-Id: I55e2f6138f69add7ffa028baab6d8ea80681acf0
stoty
commented
Jul 15, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…secondary indexes