PHOENIX-6515 Phoenix uses hbase-testing-util but does not list it as …

[richardantal]

…a dependency

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	4m 56s	Maven dependency ordering for branch
+1 💚	mvninstall	17m 0s	master passed
+0	hbaserecompile	28m 52s	HBase recompiled.
+1 💚	compile	1m 50s	master passed
+1 💚	javadoc	2m 39s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	13m 53s	the patch passed
+0	hbaserecompile	20m 47s	HBase recompiled.
+1 💚	compile	1m 47s	the patch passed
+1 💚	javac	1m 47s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 4s	The patch has no ill-formed XML file.
+1 💚	javadoc	2m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	116m 13s	root in the patch failed.
-1 ❌	asflicense	2m 19s	The patch generated 614 ASF License warnings.
		181m 8s

Reason	Tests
Failed junit tests	phoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1269/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1269
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux d62d6a53a902 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 00d9031
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1269/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1269/1/testReport/
asflicense	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1269/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count	15118 (vs. ulimit of 30000)
modules	C: phoenix-core phoenix-pherf . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1269/1/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

Testing this is a problem, as by default Phoenix won't compile with Omid-1.0.3-SNAPSHOT.
After applying both this and my WIP Omid patch #1026 I was able to run mvn clean package on Phoenix successfully.
I was also able to compile Phoenix with this patch and Phoenix 1.0.2

Don't forget to apply this to all four active branches.