PHOENIX-6519 Make SchemaTool work with lower case table and column names by richardantal · Pull Request #1275 · apache/phoenix

richardantal · 2021-07-26T14:38:39Z

No description provided.

stoty · 2021-07-26T17:59:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 12s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	5m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	20m 23s	master passed
+0	hbaserecompile	32m 34s	HBase recompiled.
+1 💚	compile	1m 39s	master passed
+1 💚	checkstyle	0m 56s	master passed
+1 💚	javadoc	1m 13s	master passed
+0 🆗	spotbugs	3m 40s	phoenix-core in master has 964 extant spotbugs warnings.
+0 🆗	spotbugs	0m 47s	phoenix-tools in master has 5 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	16m 59s	the patch passed
+0	hbaserecompile	24m 50s	HBase recompiled.
+1 💚	compile	1m 36s	the patch passed
+1 💚	javac	1m 36s	the patch passed
-1 ❌	checkstyle	0m 44s	phoenix-core: The patch generated 33 new + 712 unchanged - 0 fixed = 745 total (was 712)
-1 ❌	checkstyle	0m 16s	phoenix-tools: The patch generated 15 new + 213 unchanged - 12 fixed = 228 total (was 225)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	1m 6s	the patch passed
+1 💚	spotbugs	4m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	119m 10s	phoenix-core in the patch passed.
-1 ❌	unit	3m 30s	phoenix-tools in the patch failed.
+1 💚	asflicense	0m 24s	The patch does not generate ASF License warnings.
		199m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1275
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname	Linux 015f7b580e53 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `6842c1d`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/1/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/1/testReport/
Max. process+thread count	11543 (vs. ulimit of 30000)
modules	C: phoenix-core phoenix-tools U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty

In general, you may want to go over the code, and make variable names more consistent.
i.e. add Quoted to quoted names, etc.

stoty · 2021-07-29T06:55:23Z

 }

+ @Test
+ public void testCreateLocalIndexStatement() throws Exception {


It seems that you're also fixng some bugs WRT local indexes.
You should probablay note it at least in the commit message.

stoty · 2021-07-29T06:57:59Z

 private String generateTableDDLString(String columnInfoString, String propertiesString,
 String pSchemaName, String pTableName) {
- String pTableFullName = SchemaUtil.getPTableFullNameWithQuotes(pSchemaName, pTableName);
+ String pTableFullName = SchemaUtil.getFullTableNameWithQuotes(pSchemaName, pTableName);


You may want to go over the code, and change the quoted variable names according to some common template, to improbe readability.

stoty · 2021-07-29T07:04:07Z

+ }
+
+ private static boolean quotesNeededForColumn(String name) {
+ if (!name.equals("_INDEX_ID") && "_".equals(String.valueOf(name.charAt(0)))) {


Why do we need the special case for tables beginning with underscore ?
Also getting the first character as string would can probably done in a less circumpect way.

If we want to create a table named _FOO we need quotes around that. The same applies for column names.
The difference is that when we create an index, _INDEX_ID column is added automatically and we do not want to have quotes around that. (But it should be possible to create a table called "_INDEX_ID" even if it an abnormal name.)

Thanks for the explanation.
name.startsWith("_")
would be a far simpler check. (In the other methods as well.

Sure, I'll upload a new change soon.

Change-Id: I643ed8c3db1ec7ebd0a68b13412a22ff7249f037

stoty · 2021-07-29T12:39:16Z

+ }
+
+ public static String formatSchemaName(String name) {
+ if (quotesNeededForSchema(name)) {


Does the leading _ issue not apply here ?

It does, in quotesNeededForSchema we check for some extra schema specific stuff but I call the quotesNeededForTable there.

stoty

+1 LGTM

richardantal · 2021-07-29T13:27:06Z

Thank you @stoty for the reviews!

stoty · 2021-07-29T15:42:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	5m 5s	Maven dependency ordering for branch
+1 💚	mvninstall	19m 42s	master passed
+0	hbaserecompile	33m 45s	HBase recompiled.
+1 💚	compile	1m 51s	master passed
+1 💚	checkstyle	1m 9s	master passed
+1 💚	javadoc	1m 26s	master passed
+0 🆗	spotbugs	4m 18s	phoenix-core in master has 970 extant spotbugs warnings.
+0 🆗	spotbugs	0m 52s	phoenix-tools in master has 3 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	16m 34s	the patch passed
+0	hbaserecompile	23m 34s	HBase recompiled.
+1 💚	compile	1m 46s	the patch passed
+1 💚	javac	1m 46s	the patch passed
-1 ❌	checkstyle	0m 46s	phoenix-core: The patch generated 65 new + 909 unchanged - 27 fixed = 974 total (was 936)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	1m 16s	the patch passed
+1 💚	spotbugs	4m 59s	the patch passed
		_ Other Tests _
-1 ❌	unit	123m 16s	phoenix-core in the patch failed.
-1 ❌	unit	3m 58s	phoenix-tools in the patch failed.
+1 💚	asflicense	1m 24s	The patch does not generate ASF License warnings.
		214m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1275
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname	Linux da3954fc0345 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `d04b3d8`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/testReport/
Max. process+thread count	13954 (vs. ulimit of 30000)
modules	C: phoenix-core phoenix-tools U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1275/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

richardantal requested a review from swaroopak July 28, 2021 10:47

stoty reviewed Jul 29, 2021
View reviewed changes

PHOENIX-6519 Make SchemaTool work with lower case table and column names
1b633e5
Change-Id: I643ed8c3db1ec7ebd0a68b13412a22ff7249f037

richardantal force-pushed the PHOENIX-6519 branch from 12aa56c to 1b633e5Compare July 29, 2021 11:31

stoty reviewed Jul 29, 2021
View reviewed changes

stoty approved these changes Jul 29, 2021
View reviewed changes

richardantal merged commit fa7e8c9 into apache:masterJul 29, 2021

Navigation Menu

Uh oh!

PHOENIX-6519 Make SchemaTool work with lower case table and column names - #1275

PHOENIX-6519 Make SchemaTool work with lower case table and column names#1275
richardantal merged 1 commit into
apache:masterfrom
richardantal:PHOENIX-6519

richardantal commented Jul 26, 2021

Uh oh!

stoty commented Jul 26, 2021

Uh oh!

stoty left a comment

Uh oh!

stotyJul 29, 2021

Uh oh!

stotyJul 29, 2021

Uh oh!

stotyJul 29, 2021

Uh oh!

richardantalJul 29, 2021

Uh oh!

stotyJul 29, 2021

Uh oh!

richardantalJul 29, 2021

Uh oh!

stotyJul 29, 2021

Uh oh!

richardantalJul 29, 2021

Uh oh!

stoty left a comment

Uh oh!

richardantal commented Jul 29, 2021

Uh oh!

stoty commented Jul 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

richardantal commented Jul 26, 2021

Uh oh!

stoty commented Jul 26, 2021

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stoty left a comment

Choose a reason for hiding this comment

Uh oh!

richardantal commented Jul 29, 2021

Uh oh!

stoty commented Jul 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants