Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6450 Checkstyle creating warnings for line length > 80 but < 100 - #1276
Merged
Conversation
stoty
commented
Jul 27, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
suggested changes
Jul 29, 2021
| <antlr-output.dir>target/generated-sources/antlr3</antlr-output.dir> | ||
| <test.output.tofile>true</test.output.tofile> | ||
| <top.dir>${project.basedir}</top.dir> | ||
| <top.dir>${project.basedir}/..</top.dir> |
Contributor
There was a problem hiding this comment.
top.dir in the submodules doesn't seem to do anything.
I suggest that you delete it from those to simplify the maven setup.
Change-Id: I24ae68bb3c237e1327b2c93774727f328b11aa50
stoty
commented
Jul 29, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.