Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6472 In case of region inconsistency phoenix should stop grac… - #1288
Merged
Conversation
dbwong
reviewed
Aug 18, 2021
Uh oh!
There was an error while loading. Please reload this page.
stoty
commented
Aug 18, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Aug 18, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
dbwong
reviewed
Aug 18, 2021
dbwong
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall can we test the start/end keys explicitly? After that i'm good to +1 this.
| @@ -157,6 +159,49 @@ public void testExceptionHandlingOnSystemNamespaceCreation() throws Exception { | |||
| } | |||
| } | |||
Contributor
There was a problem hiding this comment.
Maybe one more test for the start/end keys.
dbwong
approved these changes
Aug 18, 2021
stoty
commented
Aug 19, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Aug 19, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Aug 19, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
| @@ -666,8 +681,8 @@ public List<HRegionLocation> getAllTableRegions(byte[] tableName) throws SQLExce | |||
| do { | |||
| HRegionLocation regionLocation = connection.getRegionLocation( | |||
| TableName.valueOf(tableName), currentKey, reload); | |||
ContributorAuthor
There was a problem hiding this comment.
yes, this is the reason that we need to make sure the end key always increasing.
stoty
commented
Aug 19, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…efully