Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6534 Upgrades from pre 4.10 versions are broken - #1293
Closed
stoty wants to merge 1 commit into
Closed
Conversation
stoty
commented
Sep 7, 2021
ContributorAuthor
💔 -1 overall
This message was automatically generated. |
stoty
requested review from
ankitsinghal, chrajeshbabu, joshelser, richardantal and virajjasaniSeptember 8, 2021 05:20
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
Nice find, left one question, mostly good to go otherwise.
| } else { | ||
| colUpsert.setBytes(19, column.getColumnQualifierBytes()); | ||
| } | ||
| colUpsert.setBoolean(20, column.isRowTimestamp()); |
Contributor
There was a problem hiding this comment.
Do we not need this check if (colUpsert.getParameterMetaData().getParameterCount() > 19 here?
ContributorAuthor
There was a problem hiding this comment.
No, we only have two possible upsert statements, one with 18, and one with 20 parameters.
The old version had three, so it needed both checks, but the 19 parameter one has been removed since.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch restores the correct behaviour (and largely the code) that was removed by mistake in PHOENIX-5403.