Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-1674 Snapshot isolation transaction support through Tephra - #130
PHOENIX-1674 Snapshot isolation transaction support through Tephra#130twdsilva wants to merge 0 commit into
Conversation
twdsilva
commented
Nov 20, 2015
For the last few files that aren't showing up in the diff view , you can view the diffs here |
There was a problem hiding this comment.
Will change the sqlState for this and the following exception.
samarthjain
commented
Nov 20, 2015
The check in TableRef.equals() isn't complete. It should be something like this: if (((table.getName() == null && other.table.getName() != null) |
There was a problem hiding this comment.
Instead of using System.currentMillis() in the table name (which will create a new physical table for every test), can you create a TestUtil.getTableName(String prefix, boolean localIndex, boolean mutable, boolean transactional, Integer saltBuckets) and creates a sensible table name like T_LOCAL_MUTABLE_UNSALTED.
There was a problem hiding this comment.
Will change the check in TableRef.equals to
if ((table.getName() == null && other.table.getName() != null)
|| (table.getName()!=null && !table.getName().getString().equals(other.table.getName().getString()))) return false;
@samarthjain@JamesRTaylor
Closed#129 since its missing some files.
I added the review feedback, please +1 if everything looks OK