Skip to content

PHOENIX-1674 Snapshot isolation transaction support through Tephra - #130

Closed
twdsilva wants to merge 0 commit into
apache:masterfrom
twdsilva:master
Closed

PHOENIX-1674 Snapshot isolation transaction support through Tephra#130
twdsilva wants to merge 0 commit into
apache:masterfrom
twdsilva:master

Conversation

@twdsilva

Copy link
Copy Markdown
Contributor

@samarthjain@JamesRTaylor
Closed#129 since its missing some files.
I added the review feedback, please +1 if everything looks OK

@twdsilva

Copy link
Copy Markdown
ContributorAuthor

For the last few files that aren't showing up in the diff view , you can view the diffs here
https://patch-diff.githubusercontent.com/raw/apache/phoenix/pull/130.patch

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change the sqlState for this and the following exception.

@samarthjain

Copy link
Copy Markdown
Contributor

The check in TableRef.equals() isn't complete. It should be something like this:

if (((table.getName() == null && other.table.getName() != null)
||(table.getName() != null && other.table.getName() == null)
|| !table.getName().getString().equals(other.table.getName().getString())))
return false;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using System.currentMillis() in the table name (which will create a new physical table for every test), can you create a TestUtil.getTableName(String prefix, boolean localIndex, boolean mutable, boolean transactional, Integer saltBuckets) and creates a sensible table name like T_LOCAL_MUTABLE_UNSALTED.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change the check in TableRef.equals to

if ((table.getName() == null && other.table.getName() != null)
|| (table.getName()!=null && !table.getName().getString().equals(other.table.getName().getString()))) return false;

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@twdsilva@samarthjain@JamesRTaylor