Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6541 Use ROW_TIMESTAMP column value as timestamps for conditional upsert mutations - #1300
Merged
Merged
Conversation
…onal upsert mutations
tkhurana
commented
Sep 10, 2021
ContributorAuthor
gokceni
reviewed
Sep 10, 2021
| if (!builder.isEnabled(m) && !builder.isAtomicOp(m)) { | ||
| // or if it is an atomic op and its timestamp is already set | ||
| if (!builder.isEnabled(m) && | ||
| (!builder.isAtomicOp(m) || getMaxTimestamp(m) != HConstants.LATEST_TIMESTAMP)) { |
Contributor
There was a problem hiding this comment.
Should this be && rather than ||? The comment says "and" not "or"
Contributor
There was a problem hiding this comment.
Agree with gokcen, something looks missing here.
ContributorAuthor
There was a problem hiding this comment.
@ankitjain64@gokceni It is correct but I will restructure it to make it more readable
gokceni
suggested changes
Sep 10, 2021
gokceni
left a comment
Contributor
There was a problem hiding this comment.
Either the code comment or the code needs to change
| String original = "ORIGINAL"; | ||
| String updated = "UPDATED"; | ||
| String duplicate = "DUPLICATE"; | ||
| long rowTimestamp = EnvironmentEdgeManager.currentTimeMillis() - 10; |
Contributor
There was a problem hiding this comment.
Curious is there a particular reason to subtract 10 ms from the rowTimestamp. ?
ContributorAuthor
There was a problem hiding this comment.
@ankitjain64 We just wanted a value that is less than the current time. 10 is chosen arbitrarily.
| } | ||
| ResultSet rs = stmt.executeQuery(); | ||
| assertTrue(rs.next()); | ||
| assertEquals(count, rs.getInt(1)); |
Contributor
There was a problem hiding this comment.
from the jira description looks like we want to make sure correct timestamps are used for the mutation but we are not validating that in the test case and just the row count. Is that sufficient @tkhurana ?
ContributorAuthor
There was a problem hiding this comment.
@ankitjain64 I was able to repro the problem with just checking row count but I will add the asserts for timestamps also
stoty
commented
Sep 11, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Sep 14, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126
commented
Sep 14, 2021
Contributor
@ankitjain64 - do you have any other comments or suggestions for this PR? Otherwise I will merge. |
ankitjain64
commented
Sep 14, 2021
Contributor
Sure, you can merge this PR. |
gjacoby126 pushed a commit
that referenced
this pull request
Sep 14, 2021
…onal upsert mutations (#1300)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.