Skip to content

PHOENIX-6543 de-flake AuditLoggingIT - #1302

Closed
stoty wants to merge 2 commits into
apache:masterfrom
stoty:PHOENIX-6543
Closed

PHOENIX-6543 de-flake AuditLoggingIT#1302
stoty wants to merge 2 commits into
apache:masterfrom
stoty:PHOENIX-6543

Conversation

@stoty

Copy link
Copy Markdown
Contributor

No description provided.

assertEquals(rs2.getString(7), selectQuery);
assertFalse(rs2.next());
break;
} catch (AssertionFailedError e) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we catch AssertionError instead of AssertionFailedError?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you are right.
Fixed.

@stoty

Copy link
Copy Markdown
ContributorAuthor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 31sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall30m 6smaster passed
+0hbaserecompile39m 37sHBase recompiled.
+1 💚compile1m 28smaster passed
+1 💚checkstyle1m 18smaster passed
+1 💚javadoc1m 16smaster passed
+0 🆗spotbugs4m 18sphoenix-core in master has 972 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall23m 47sthe patch passed
+0hbaserecompile37m 50sHBase recompiled.
+1 💚compile1m 37sthe patch passed
+1 💚javac1m 37sthe patch passed
+1 💚checkstyle1m 20sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 10sthe patch passed
+1 💚spotbugs4m 31sthe patch passed
_ Other Tests _
-1 ❌unit158m 47sphoenix-core in the patch failed.
+1 💚asflicense0m 52sThe patch does not generate ASF License warnings.
255m 43s
ReasonTests
Failed junit testsphoenix.end2end.index.IndexMetadataIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1302
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 58d61de4c478 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / e84232b
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/1/testReport/
Max. process+thread count6223 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

Copy link
Copy Markdown
ContributorAuthor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall20m 57smaster passed
+0hbaserecompile27m 43sHBase recompiled.
+1 💚compile1m 3smaster passed
+1 💚checkstyle0m 55smaster passed
+1 💚javadoc0m 51smaster passed
+0 🆗spotbugs3m 7sphoenix-core in master has 972 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall13m 28sthe patch passed
+0hbaserecompile23m 26sHBase recompiled.
+1 💚compile1m 2sthe patch passed
+1 💚javac1m 2sthe patch passed
+1 💚checkstyle0m 56sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 51sthe patch passed
+1 💚spotbugs3m 15sthe patch passed
_ Other Tests _
-1 ❌unit112m 27sphoenix-core in the patch failed.
+1 💚asflicense0m 43sThe patch does not generate ASF License warnings.
180m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1302
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux af669b73ec5f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / c55b472
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/2/testReport/
Max. process+thread count15010 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1302/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@richardantalrichardantal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stotystoty closed this Sep 14, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stoty@richardantal