PHOENIX-6553 Sync phoenix-pherf in 4.16 to 4.x

[stoty]

This patch simply copies the 4.x directory onto the 4.16 one. (and reverts the project version in the pom so that it builds)

[stoty]

@jpisaac I cannot request a review from you for some reason, but PTAL.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 17s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 2s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 25 new or modified test files.
		_ 4.16 Compile Tests _
+1 💚	mvninstall	18m 27s	4.16 passed
+1 💚	compile	0m 36s	4.16 passed
+1 💚	checkstyle	0m 23s	4.16 passed
+1 💚	javadoc	0m 16s	4.16 passed
+0 🆗	spotbugs	0m 53s	phoenix-pherf in 4.16 has 42 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	9m 43s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
-1 ❌	checkstyle	0m 28s	phoenix-pherf: The patch generated 294 new + 424 unchanged - 42 fixed = 718 total (was 466)
-1 ❌	whitespace	0m 0s	The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌	whitespace	0m 0s	The patch 32 line(s) with tabs.
+1 💚	xml	0m 16s	The patch has no ill-formed XML file.
-1 ❌	javadoc	0m 16s	phoenix-pherf generated 26 new + 32 unchanged - 0 fixed = 58 total (was 32)
-1 ❌	spotbugs	1m 10s	phoenix-pherf generated 6 new + 41 unchanged - 1 fixed = 47 total (was 42)
		_ Other Tests _
+1 💚	unit	8m 48s	phoenix-pherf in the patch passed.
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		47m 32s

Reason	Tests
FindBugs	module:phoenix-pherf
	Found reliance on default encoding in org.apache.phoenix.pherf.util.PhoenixUtil.buildStatement(RulesApplier, Scenario, List, PreparedStatement, SimpleDateFormat):in org.apache.phoenix.pherf.util.PhoenixUtil.buildStatement(RulesApplier, Scenario, List, PreparedStatement, SimpleDateFormat): String.getBytes() At PhoenixUtil.java:[line 570]
	Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At RendezvousingWorkHandler.java:but method has no side effect At RendezvousingWorkHandler.java:[line 83]
	Return value of org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.getPhoenixUtil() ignored, but method has no side effect At TenantOperationWorkHandler.java:but method has no side effect At TenantOperationWorkHandler.java:[line 67]
	A prepared statement is generated from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:from a nonconstant String in org.apache.phoenix.pherf.workload.mt.operations.PreScenarioOperationSupplier$1.apply(TenantOperationInfo) At PreScenarioOperationSupplier.java:[line 74]
	Impossible cast from RuntimeException to java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:java.sql.SQLException in org.apache.phoenix.pherf.workload.mt.operations.TenantOperationFactory.executePreRunOpsForTenant(TenantOperationFactory$TenantView, TenantOperationInfo) At TenantOperationFactory.java:[line 354]
	org.apache.phoenix.pherf.workload.mt.operations.UpsertOperationSupplier$1.apply(TenantOperationInfo) may fail to clean up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:up java.sql.Statement Obligation to clean up resource created at UpsertOperationSupplier.java:[line 107] is not discharged

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1315/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1315
Optional Tests	dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle
uname	Linux 0c8a7a0f2937 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.16 / 238fcd7
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1315/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
whitespace	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1315/1/artifact/yetus-general-check/output/whitespace-eol.txt
whitespace	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1315/1/artifact/yetus-general-check/output/whitespace-tabs.txt
javadoc	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1315/1/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-pherf.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1315/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-pherf.html
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1315/1/testReport/
Max. process+thread count	2589 (vs. ulimit of 30000)
modules	C: phoenix-pherf U: phoenix-pherf
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1315/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[virajjasani]

+1, Since this patch brings 4.16 in sync, good to ship it as is, and for checkstyle/spotbugs/whitespace etc, we can work as separate Jira and fix for all applicable branches.