Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6234 - Replace Guava with phoenix-thirdparty version in 4.x - #1317
Merged
Conversation
stoty
commented
Sep 20, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
approved these changes
Sep 21, 2021
stoty
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
Could you please clean up the version handling in the poms before commit ?
| </dependency> | ||
| <!-- Transaction dependencies --> | ||
| <!-- |
Contributor
There was a problem hiding this comment.
Nit: delete instead of commenting out
| <dependency> | ||
| <groupId>org.apache.tephra</groupId> | ||
| <artifactId>tephra-core</artifactId> | ||
| <version>${tephra.version}</version> |
Contributor
There was a problem hiding this comment.
The versions should be defined in the top project dependencyManagement section
| @@ -118,6 +123,7 @@ | |||
| <dependency> | |||
| <groupId>org.apache.tephra</groupId> | |||
| <artifactId>tephra-core</artifactId> | |||
| <version>${tephra.version}</version> | |||
Contributor
There was a problem hiding this comment.
This should already be dependencyMananged in the top pom
| <dependency> | ||
| <groupId>org.apache.tephra</groupId> | ||
| <artifactId>tephra-hbase-compat-${tephra.hbase.compat.version}</artifactId> | ||
| <version>${tephra.version}</version> |
Contributor
There was a problem hiding this comment.
The versions should be defined in the top project dependencyManagement section
| @@ -173,6 +173,7 @@ | |||
| <dependency> | |||
| <groupId>org.apache.tephra</groupId> | |||
| <artifactId>tephra-core</artifactId> | |||
| <version>${tephra.version}</version> | |||
Contributor
There was a problem hiding this comment.
The versions should be defined in the top project dependencyManagement section
(Why do we even have test dependencies in phoenix-server ? - that's a question for another day)
virajjasani
approved these changes
Sep 21, 2021
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
+1 overall, worth fixing the above comments
gjacoby126
commented
Sep 21, 2021
ContributorAuthor
Fixed the versions (which revealed some extra unshaded twill dependencies in UpdateStatisticsTool) and reran tests locally which passed. Merging and then will backport to 4.16. Thanks for the reviews @stoty and @virajjasani ! |
stoty
commented
Sep 21, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.