Skip to content

Change concat Strings in foreach to StringBuilder.#160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Boruch28 wants to merge 1 commit into
base:master
Choose a base branch
from
Open

Change concat Strings in foreach to StringBuilder. #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 20 additions & 13 deletions phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/GoogleChartGenerator.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -163,7 +163,7 @@ private void renderAsGoogleChartsHTML() throws FileNotFoundException, Unsupporte
sb.append("dataTable.addRows([\n");
for (Map.Entry<String, DataNode> dn : datanodes.entrySet()) {
String currentKeyPrefix = dn.getKey().substring(0, dn.getKey().indexOf('|'));
if (!lastKeyPrefix.equalsIgnoreCase(currentKeyPrefix) && lastKeyPrefix != "") {
if (!lastKeyPrefix.equalsIgnoreCase(currentKeyPrefix) && !lastKeyPrefix.equals("")) {
sb.append(getBlankRow());
}
lastKeyPrefix = currentKeyPrefix;
Expand All@@ -183,7 +183,7 @@ private void renderAsGoogleChartsHTML() throws FileNotFoundException, Unsupporte
String thresholdString = Math.round((threshold*100)) + "%";
String footer = StaticGoogleChartsRenderingData.FOOTER
.replace("[summary]",
((verifyWithinThreshold(threshold) == true ? "<font color=green>PASSED | Results are within ":
((verifyWithinThreshold(threshold) ? "<font color=green>PASSED | Results are within ":
"<font color=red>FAILED | Results are outside "))
+ "set threshold of " + thresholdString + "</font><br>"
+ new SimpleDateFormat("yyyy/MM/dd ha z").format(new Date()));
Expand All@@ -197,23 +197,30 @@ private void renderAsGoogleChartsHTML() throws FileNotFoundException, Unsupporte
* @return
*/
private String getBlankRow() {
String ret = "['" + new String(new char[60]).replace("\0", ".") + "'";
for (int i=0; i<labels.length; i++)
ret += ",0,''";
ret += "],";
return ret;
}
StringBuilder sb = new StringBuilder("['");
sb.append(new String(new char[60]).replace("\0", "."));
sb.append("'");
for (int i = 0; i < labels.length; i++) {
sb.append(",0,''");
}
sb.append("],");
return sb.toString();
}

/**
* Render tooltip as HTML table
* @param nodeDataSet
* @return
*/
private String getToolTipAsHTML(Map<String, Node> nodeDataSet) {
String ret = "<table width=1000 cellpadding=1 cellspacing=0 border=0 bgcolor=#F4F4F4><tr>";
for (Map.Entry<String, Node> nodeSet : nodeDataSet.entrySet())
ret += "<td>" + getToolText(nodeSet.getValue()) + "</td>";
return ret + "</tr></table>";
private String getToolTipAsHTML(Map<String, Node> nodeDataSet) {
StringBuilder sb = new StringBuilder("<table width=1000 cellpadding=1 cellspacing=0 border=0 bgcolor=#F4F4F4><tr>");
for (Map.Entry<String, Node> nodeSet : nodeDataSet.entrySet()) {
sb.append("<td>");
sb.append(getToolText(nodeSet.getValue()));
sb.append("</td>");
}
sb.append("</tr></table>");
return sb.toString();
}

/**
Expand Down