Skip to content

Handling the situation when hashCode == Integer.MIN_VALUE#164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Boruch28 wants to merge 1 commit into
base:master
Choose a base branch
from
Open

Handling the situation when hashCode == Integer.MIN_VALUE #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion phoenix-core/src/main/java/org/apache/phoenix/cache/aggcache/SpillManager.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -247,8 +247,13 @@ public <K extends ImmutableBytesWritable> CacheEntry<K> toCacheEntry(byte[] byte

// Determines the partition, i.e. spillFile the tuple should get spilled to.
private int getPartition(ImmutableBytesWritable key) {
int hashCode = key.hashCode();
// *Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE
if (hashCode == Integer.MIN_VALUE) {
hashCode = hashCode >> 1;
}
// Simple implementation hash mod numFiles
return Math.abs(key.hashCode()) % numSpillFiles;
return Math.abs(hashCode) % numSpillFiles;
}

/**
Expand Down