Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-7892 Fix MutableIndexIT EXPLAIN assertions for projection filters - #2511
Merged
Merged
Conversation
…ters
MutableIndexIT was refactored to ExplainPlanAttributes earlier and was not
updated by PHOENIX-7886, so its testCompoundIndexKey and
testMultipleUpdatesToSingleRow cases still assert
serverWhereFilter("SERVER FILTER BY ... ONLY"), which is now null, producing
10 failures across the parameterized configurations. Switch those assertions
to serverProjectionFilter(columnEncoded), matching the BaseIndexIT pattern.
Full MutableIndexIT now passes.There was a problem hiding this comment.
Pull request overview
Updates MutableIndexIT EXPLAIN plan assertions to align with the post-refactor ExplainPlanAttributes representation of projection-only scans, fixing failures introduced by earlier changes where the old serverWhereFilter("... ONLY") expectation is now null.
Changes:
- Replace
serverWhereFilter("SERVER FILTER BY ... ONLY")assertions withserverProjectionFilter(columnEncoded)intestCompoundIndexKey. - Replace
serverWhereFilter("SERVER FILTER BY ... ONLY")assertions withserverProjectionFilter(columnEncoded)intestMultipleUpdatesToSingleRow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apurtell added a commit
to apurtell/phoenix
that referenced
this pull request
Jun 17, 2026
…ters (apache#2511) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
asf-gitbox-commits pushed a commit
that referenced
this pull request
Jul 24, 2026
…ters (#2511) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
apurtell added a commit
to apurtell/phoenix
that referenced
this pull request
Aug 4, 2026
…ters (apache#2511) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MutableIndexITwas refactored toExplainPlanAttributesearlier and was not updated by PHOENIX-7886, so itstestCompoundIndexKeyandtestMultipleUpdatesToSingleRowcases still assertserverWhereFilter("SERVER FILTER BY ... ONLY"), which is nownull, producing 10 failures across the parameterized configurations. Switch those assertions toserverProjectionFilter(columnEncoded), matching theBaseIndexITpattern. FullMutableIndexITnow passes.Co-authored-by: Claude Opus 4.8[1m] noreply@anthropic.com