Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-7897 Fix JoinQueryCompilerTest EXPLAIN assertions for HASH BUILD decorations - #2514
Merged
Merged
Conversation
…ILD decorations PHOENIX-7890 added the "/* HASH BUILD LEFT|RIGHT */" decoration to the join sub-plan headers in HashJoinPlan.buildHeader but did not update JoinQueryCompilerTest.testExplainPlan. Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates JoinQueryCompilerTest.testExplainPlan to match the new /* HASH BUILD LEFT|RIGHT */ decorations added to join sub-plan headers (introduced in PHOENIX-7890 via HashJoinPlan.buildHeader), ensuring EXPLAIN-plan assertions remain accurate.
Changes:
- Adjusts
abstractExplainPlan(...)expected strings to include/* HASH BUILD LEFT */and/* HASH BUILD RIGHT */decorations (with correct spacing). - Adds clarifying comments describing why the outer vs nested subplans use LEFT vs RIGHT hash-build markers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apurtell added a commit
to apurtell/phoenix
that referenced
this pull request
Jun 17, 2026
…ILD decorations (apache#2514) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
asf-gitbox-commits pushed a commit
that referenced
this pull request
Jul 24, 2026
…ILD decorations (#2514) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
apurtell added a commit
to apurtell/phoenix
that referenced
this pull request
Aug 4, 2026
…ILD decorations (apache#2514) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHOENIX-7890 added the
/* HASH BUILD LEFT|RIGHT */decoration to the join sub-plan headers inHashJoinPlan.buildHeaderbut did not updateJoinQueryCompilerTest.testExplainPlan.Co-authored-by: Claude Opus 4.8[1m] noreply@anthropic.com