Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-7928 Re-baseline some missed tests - #2533
Merged
Merged
Conversation
Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates several integration tests’ expected outputs (“re-baselines”) to match current Phoenix behavior, particularly around DDL rendering and optimizer explain-plan rule labels.
Changes:
- Update SchemaTool extraction test expectations to match current whitespace formatting in generated DDL.
- Update explain-plan assertions to account for functional-index rule labels now emitted as
matches <expr>(using prefix assertions). - Update CDC index PK column name expectations to match current formatting (no space after
:).
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| phoenix-core/src/it/java/org/apache/phoenix/schema/tool/SchemaToolExtractionIT.java | Align expected extracted index DDL formatting (LPAD expression spacing). |
| phoenix-core/src/it/java/org/apache/phoenix/end2end/json/JsonFunctionsIT.java | Adjust explain-plan rule assertion for JSON expression index selection. |
| phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexUsageIT.java | Re-baseline multiple explain-plan rule assertions for expression/functional index usage. |
| phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCDefinitionIT.java | Update expected CDC index PK column names to match current output formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apurtell added a commit
to apurtell/phoenix
that referenced
this pull request
Jun 17, 2026
Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
asf-gitbox-commits pushed a commit
that referenced
this pull request
Jul 24, 2026
Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
apurtell added a commit
to apurtell/phoenix
that referenced
this pull request
Aug 4, 2026
Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests that should have been updated during development were not updated. Re-baseline them.
IndexUsageIT (30), JsonFunctionsIT (1), SchemaToolExtractionIT (2), and CDCDefinitionIT (2)