Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-7937 Trim whitespace in EXPLAIN FORMAT JSON scan attributes - #2546
Conversation
Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR canonicalizes (trims) whitespace in scan-related string fields when populating ExplainPlanAttributes for EXPLAIN FORMAT JSON, while keeping the human-readable/text explain output unchanged.
Changes:
- Trim
explainScanTypebefore storing it inExplainPlanAttributes. - Trim
keyRangesbefore storing it inExplainPlanAttributes. - Update/adjust JSON-baseline expectations in
ExplainPlanTestto match the canonicalized output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
phoenix-core/src/test/java/org/apache/phoenix/query/explain/ExplainPlanTest.java | Updates expected JSON attributes to match trimmed/canonical scan attribute strings; trims inputs in helper used to build expected scan JSON. |
phoenix-core-client/src/main/java/org/apache/phoenix/iterate/ExplainTable.java | Trims scan attribute string values (explainScanType, keyRanges) when populating ExplainPlanAttributes for JSON output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…pache#2546) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
…pache#2546) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
…pache#2546) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
apurtell
commented
Jun 25, 2026
This one is annoying because it had a much larger silly impact on tests than expected, and sometimes you just have to grab the IDE and do it by hand. I think I have a handle on it now. |
…pache#2546) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
…pache#2546) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
…2546) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
…pache#2546) Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>
Trim scan attribute string values before populating
ExplainPlanAttributes. Text plan is unchanged. The JSON field values are canonicalized.Co-authored-by: Claude Opus 4.8[1m] noreply@anthropic.com