Skip to content

PHOENIX-4902 Use only compressed portion of hash cache memory buffer - #349

Open
ortutay wants to merge 1 commit into
apache:masterfrom
ortutay:PHOENIX-4902-snappy-compression-fix
Open

PHOENIX-4902 Use only compressed portion of hash cache memory buffer#349
ortutay wants to merge 1 commit into
apache:masterfrom
ortutay:PHOENIX-4902-snappy-compression-fix

Conversation

@ortutay

@ortutayortutay commented Sep 16, 2018

Copy link
Copy Markdown
Contributor

See ticket https://issues.apache.org/jira/browse/PHOENIX-4902 for description of issue. Current code loses Snappy compression benefits, this change makes sure only the compressed portion is sent in the RPC message.

@ortutay

Copy link
Copy Markdown
ContributorAuthor

Ping, please let me know if there are any issues with this PR

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 52sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall17m 1smaster passed
+0hbaserecompile24m 12sHBase recompiled.
+1 💚compile1m 15smaster passed
+1 💚checkstyle0m 34smaster passed
+1 💚javadoc0m 52smaster passed
+0 🆗spotbugs3m 43sphoenix-core in master has 959 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall10m 13sthe patch passed
+0hbaserecompile21m 18sHBase recompiled.
+1 💚compile1m 15sthe patch passed
+1 💚javac1m 15sthe patch passed
+1 💚checkstyle0m 38sphoenix-core: The patch generated 0 new + 101 unchanged - 2 fixed = 101 total (was 103)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 58sthe patch passed
+1 💚spotbugs3m 56sthe patch passed
_ Other Tests _
-1 ❌unit118m 0sphoenix-core in the patch failed.
+1 💚asflicense0m 38sThe patch does not generate ASF License warnings.
182m 29s
ReasonTests
Failed junit testsphoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT
phoenix.end2end.UpsertSelectIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#349
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 4c1eb8b054b3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 6ed3caf
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/testReport/
Max. process+thread count9636 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 29sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 1sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall27m 11smaster passed
+0hbaserecompile35m 48sHBase recompiled.
+1 💚compile1m 20smaster passed
+1 💚checkstyle1m 9smaster passed
+1 💚javadoc1m 0smaster passed
+0 🆗spotbugs3m 54sphoenix-core in master has 970 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall18m 49sthe patch passed
+0hbaserecompile31m 28sHBase recompiled.
+1 💚compile1m 13sthe patch passed
+1 💚javac1m 13sthe patch passed
+1 💚checkstyle0m 59sphoenix-core: The patch generated 0 new + 44 unchanged - 2 fixed = 44 total (was 46)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 56sthe patch passed
+1 💚spotbugs3m 35sthe patch passed
_ Other Tests _
-1 ❌unit114m 4sphoenix-core in the patch failed.
+1 💚asflicense0m 49sThe patch does not generate ASF License warnings.
201m 10s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#349
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 65a28e9d6a07 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / a4f0304
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/testReport/
Max. process+thread count14741 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Sep 7, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec7m 57sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall27m 29smaster passed
+0hbaserecompile35m 50sHBase recompiled.
+1 💚compile1m 12smaster passed
+1 💚checkstyle1m 6smaster passed
+1 💚javadoc1m 0smaster passed
+0 🆗spotbugs3m 37sphoenix-core in master has 972 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall21m 58sthe patch passed
+0hbaserecompile33m 17sHBase recompiled.
+1 💚compile1m 14sthe patch passed
+1 💚javac1m 14sthe patch passed
+1 💚checkstyle1m 4sphoenix-core: The patch generated 0 new + 44 unchanged - 2 fixed = 44 total (was 46)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 57sthe patch passed
+1 💚spotbugs3m 48sthe patch passed
_ Other Tests _
+1 💚unit125m 23sphoenix-core in the patch passed.
+1 💚asflicense0m 17sThe patch does not generate ASF License warnings.
214m 21s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#349
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux e8c706b95663 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 67cef07
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/testReport/
Max. process+thread count11386 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-349/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ortutay@stoty