PHOENIX-6151 Switch phoenix-client to shade-by-default mode

[stoty]

No description provided.

[stoty]

Unfortunately we don't have tests to thoroughly check the shaded client.
I have run a proprietary test suite on this that runs tests via sqlline, and it didn't throw up any errors.

[stoty]

rebased and reverted to using <shaded.package> as the package prefix property. (No changes in the shading)

[joshelser]

Changes look fine. Let me give them a test-drive.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	4m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	7m 51s	master passed
+1 💚	compile	1m 18s	master passed
+1 💚	javadoc	1m 19s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	32m 21s	the patch passed
+1 💚	compile	1m 18s	the patch passed
+1 💚	javac	1m 18s	the patch passed
-1 ❌	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	javadoc	1m 14s	the patch passed
		_ Other Tests _
-1 ❌	unit	163m 34s	root in the patch failed.
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		217m 59s

Reason	Tests
Failed junit tests	phoenix.end2end.ConcurrentMutationsExtendedIT
	phoenix.end2end.join.SubqueryUsingSortMergeJoinIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#890
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux 8f22da7b028c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 92e5908
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
whitespace	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/2/artifact/yetus-general-check/output/whitespace-eol.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/2/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/2/testReport/
Max. process+thread count	6865 (vs. ulimit of 30000)
modules	C: phoenix-client . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/2/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[joshelser]

Was able to run these changes with YCSB locally. I'm sure we'll find some issues, but getting it committed will speed that up. So, +1 from me.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	3m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	7m 43s	master passed
+1 💚	compile	1m 17s	master passed
+1 💚	javadoc	1m 20s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	32m 58s	the patch passed
+1 💚	compile	1m 15s	the patch passed
+1 💚	javac	1m 15s	the patch passed
-1 ❌	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	xml	0m 3s	The patch has no ill-formed XML file.
+1 💚	javadoc	1m 13s	the patch passed
		_ Other Tests _
-1 ❌	unit	167m 6s	root in the patch failed.
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		220m 53s

Reason	Tests
Failed junit tests	phoenix.end2end.TableSnapshotReadsMapReduceIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#890
Optional Tests	dupname asflicense javac javadoc unit xml compile
uname	Linux e650349662a8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 92e5908
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
whitespace	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/3/artifact/yetus-general-check/output/whitespace-eol.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/3/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/3/testReport/
Max. process+thread count	6497 (vs. ulimit of 30000)
modules	C: phoenix-client . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-890/3/console
versions	git=2.7.4 maven=3.3.9
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.