PHOENIX-6146 Run precommit checks on github PRs

[stoty]

No description provided.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	docker	4	Dockerfile '/Users/stoty/yetusdir/component/dev/docker/Dockerfile.yetus' not found.

Subsystem	Report/Notes
JIRA Issue	PHOENIX-5032
JIRA Patch URL	https://issues.apache.org/jira/secure/attachment/13011312/PHOENIX-5032.4.x.v1.patch
versions	git=2.28.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 44s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	shellcheck	0m 0s	There were no new shellcheck issues.
-1 ❌	shelldocs	0m 2s	The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	yamllint	0m 1s	The patch generated 4 new + 3 unchanged - 0 fixed = 7 total (was 3)
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		6m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-895/14/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#895
Optional Tests	dupname asflicense yamllint shellcheck shelldocs
uname	Linux f2448cb4560a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / d14e3d0
shelldocs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-895/14/artifact/yetus-general-check/output/diff-patch-shelldocs.txt
yamllint	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-895/14/artifact/yetus-general-check/output/diff-patch-yamllint.txt
Max. process+thread count	47 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-895/14/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.7.0 yamllint=1.20.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 23s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	shelldocs	0m 2s	There were no new shelldocs issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	yamllint	0m 0s	There were no new yamllint issues.
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		2m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-895/15/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#895
Optional Tests	dupname asflicense yamllint shellcheck shelldocs
uname	Linux d2e6e7b14de1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / d14e3d0
Max. process+thread count	47 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-895/15/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.7.0 yamllint=1.20.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	shellcheck	0m 0s	There were no new shellcheck issues.
+1 💚	shelldocs	0m 2s	There were no new shelldocs issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	yamllint	0m 1s	There were no new yamllint issues.
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		1m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-895/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#895
Optional Tests	dupname asflicense yamllint shellcheck shelldocs
uname	Linux ae8f82ed15b2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / d14e3d0
Max. process+thread count	47 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-895/1/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.7.0 yamllint=1.20.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[joshelser]

Is see that Yetus didn't run any of the java based tests. I'm assuming that's because Yetus was smart enough to know that it didn't need to. Have you tested to make sure that when there is a change, we get unit tests run?

I think even if you haven't, I'm happy to just see this wired up. Iteration on testing is better than the current state.

[stoty]

Thank you @joshelser .

I haven't actually tested the Java part on that on GitHub integration, but the Jenkins patch job uses the same personality, and almost the same Yetus options, so I'd be very surprised if it didn't work.

It's probably going to need an addendum or three as we start using it anger anyway, just as you've said.