PHOENIX-6158 create table/view should not update VIEW_INDEX_ID_DATA_T…

[yanxinyi]

…YPE column

[gjacoby126]

Just a couple of tiny nits, then +1

[yanxinyi]

Just a couple of tiny nits, then +1

Thanks for spending time and reviewing here :)

[ChinmaySKulkarni]

+1 lgtm

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 22s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	11m 37s	4.x passed
+1 💚	compile	1m 0s	4.x passed
+1 💚	checkstyle	1m 16s	4.x passed
+1 💚	javadoc	0m 45s	4.x passed
+0 🆗	spotbugs	3m 6s	phoenix-core in 4.x has 953 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 17s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
-1 ❌	checkstyle	1m 16s	phoenix-core: The patch generated 3 new + 2823 unchanged - 1 fixed = 2826 total (was 2824)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 45s	the patch passed
+1 💚	spotbugs	3m 20s	the patch passed
		_ Other Tests _
-1 ❌	unit	177m 35s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		217m 16s

Reason	Tests
Failed junit tests	TEST-[InQueryIT_0]

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-898/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#898
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux a5510bc4c95a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / ac0538b
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-898/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-898/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-898/4/testReport/
Max. process+thread count	5971 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-898/4/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.