Skip to content

PHOENIX-6159 Phoenix-pherf writes the result file even disableRuntimeResult flag i… - #899

Closed
yanxinyi wants to merge 1 commit into
apache:4.xfrom
yanxinyi:PHOENIX-6159
Closed

PHOENIX-6159 Phoenix-pherf writes the result file even disableRuntimeResult flag i…#899
yanxinyi wants to merge 1 commit into
apache:4.xfrom
yanxinyi:PHOENIX-6159

Conversation

@yanxinyi

Copy link
Copy Markdown
Contributor

…s true

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚mvninstall8m 36s4.x passed
+1 💚compile0m 29s4.x passed
+1 💚checkstyle0m 12s4.x passed
+1 💚javadoc0m 16s4.x passed
+0 🆗spotbugs0m 51sphoenix-pherf in 4.x has 42 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall4m 56sthe patch passed
+1 💚compile0m 29sthe patch passed
+1 💚javac0m 29sthe patch passed
-1 ❌checkstyle0m 13sphoenix-pherf: The patch generated 7 new + 101 unchanged - 3 fixed = 108 total (was 104)
-1 ❌whitespace0m 0sThe patch 1 line(s) with tabs.
+1 💚javadoc0m 15sthe patch passed
+1 💚spotbugs1m 0sthe patch passed
_ Other Tests _
+1 💚unit7m 41sphoenix-pherf in the patch passed.
+1 💚asflicense0m 10sThe patch does not generate ASF License warnings.
30m 33s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-899/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#899
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 24b2b26272ce 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / fe03af0
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-899/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt
whitespacehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-899/1/artifact/yetus-general-check/output/whitespace-tabs.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-899/1/testReport/
Max. process+thread count1795 (vs. ulimit of 30000)
modulesC: phoenix-pherf U: phoenix-pherf
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-899/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@yanxinyiyanxinyi changed the title Phoenix-pherf writes the result file even disableRuntimeResult flag i…PHOENIX-6159 Phoenix-pherf writes the result file even disableRuntimeResult flag i…Sep 28, 2020

@jpisaacjpisaac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@yanxinyiyanxinyi closed this Oct 1, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yanxinyi@stoty@jpisaac