Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6172 Updating VIEW_INDEX_ID column type and ts in Syscat with… - #908
Closed
yanxinyi wants to merge 1 commit into
Closed
PHOENIX-6172 Updating VIEW_INDEX_ID column type and ts in Syscat with…#908yanxinyi wants to merge 1 commit into
yanxinyi wants to merge 1 commit into
Conversation
stoty
commented
Oct 3, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
stoty
commented
Oct 16, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Oct 16, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
| metaConnection, rowKey, tableName.getBytes()); | ||
| LOGGER.info("Updated VIEW_INDEX_ID data type from SMALLINT TO BIGINT."); | ||
| } catch (Exception e) { | ||
| LOGGER.error("Updating VIEW_INDEX_ID data type failed."); |
Contributor
There was a problem hiding this comment.
Change to : LOGGER.error(" ... ", e) so we see the actual error too
Contributor
There was a problem hiding this comment.
Or maybe that's not required since you're already catching the exception and logging it inside the updateViewIndexIdColumnDataTypeFromShortToLong() method. Can this method still throw then?
| LOGGER.info("Updated VIEW_INDEX_ID data type from SMALLINT TO BIGINT."); | ||
| } catch (Exception e) { | ||
| LOGGER.error("Updating VIEW_INDEX_ID data type failed."); | ||
Contributor
There was a problem hiding this comment.
nit: Remove extra new line
ChinmaySKulkarni
approved these changes
Oct 17, 2020
ChinmaySKulkarni
left a comment
Contributor
There was a problem hiding this comment.
+1 after review comments addressed
yanxinyiforce-pushed
the
PHOENIX-6172-4.X
branch
from
October 17, 2020 03:18
62acff3 to
8671a95Comparestoty
commented
Oct 17, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
… a 4.16 upgrade script
yanxinyiforce-pushed
the
PHOENIX-6172-4.X
branch
from
October 17, 2020 04:37
8671a95 to
236b258Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… a 4.16 upgrade script