Skip to content

PHOENIX-6170 PHOENIX_TTL spec should be in seconds instead of milliseconds - #912

Closed
jpisaac wants to merge 1 commit into
apache:4.xfrom
jpisaac:PHOENIX-6170-PR
Closed

PHOENIX-6170 PHOENIX_TTL spec should be in seconds instead of milliseconds#912
jpisaac wants to merge 1 commit into
apache:4.xfrom
jpisaac:PHOENIX-6170-PR

Conversation

@jpisaac

Copy link
Copy Markdown
Contributor

No description provided.

@jpisaac

Copy link
Copy Markdown
ContributorAuthor

@yanxinyi@ChinmaySKulkarni Please review

@stoty

stoty commented Oct 6, 2020

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 26sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚mvninstall8m 34s4.x passed
+1 💚compile0m 58s4.x passed
+1 💚checkstyle0m 33s4.x passed
+1 💚javadoc0m 44s4.x passed
+0 🆗spotbugs2m 50sphoenix-core in 4.x has 957 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall4m 49sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
-1 ❌checkstyle0m 34sphoenix-core: The patch generated 1 new + 163 unchanged - 0 fixed = 164 total (was 163)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 44sthe patch passed
+1 💚spotbugs3m 4sthe patch passed
_ Other Tests _
-1 ❌unit127m 47sphoenix-core in the patch failed.
+1 💚asflicense0m 39sThe patch does not generate ASF License warnings.
160m 18s
ReasonTests
Failed junit testsphoenix.end2end.AlterTableWithViewsIT
phoenix.end2end.OrphanViewToolIT
phoenix.end2end.BackwardCompatibilityIT
phoenix.end2end.ViewIT
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-912/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#912
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux a24debc49af0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / 3008ca9
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-912/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-912/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-912/1/testReport/
Max. process+thread count6948 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-912/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@jpisaac

Copy link
Copy Markdown
ContributorAuthor

@sukumaddineni

@gjacoby126

Copy link
Copy Markdown
Contributor

JIRA is marked resolved, closing PR

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jpisaac@stoty@gjacoby126@yanxinyi