Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view - #917
Closed
virajjasani wants to merge 3 commits into
Closed
PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view#917virajjasani wants to merge 3 commits into
virajjasani wants to merge 3 commits into
Conversation
stoty
commented
Oct 13, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Oct 13, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
virajjasani
commented
Oct 14, 2020
ContributorAuthor
It's strange that build data is not present over ci-hadoop jenkins. |
stoty
commented
Oct 14, 2020
Contributor
It is indeed. |
virajjasani
commented
Oct 14, 2020
ContributorAuthor
Thanks @stoty for taking a look. |
virajjasani
commented
Oct 14, 2020
ContributorAuthor
INFRA Jira is filed. FYI https://issues.apache.org/jira/browse/INFRA-20984 |
stoty
commented
Oct 15, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
virajjasani
commented
Oct 15, 2020
ContributorAuthor
@ChinmaySKulkarni@gjacoby126 could you please review this PR? |
stoty
commented
Oct 15, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Oct 16, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
yanxinyi
commented
Oct 17, 2020
Contributor
LGTM +1. |
| @BeforeClass | ||
| public static synchronized void doSetup() throws Exception { | ||
| Map<String, String> serverProps = Maps.newHashMapWithExpectedSize(1); | ||
| serverProps.put(QueryServices.ALLOW_SPLITTABLE_SYSTEM_CATALOG_ROLLBACK, "true"); |
Contributor
There was a problem hiding this comment.
I think Phoenix already tested add/dropColumnOnParentTableView when ALLOW_SPLITTABLE_SYSTEM_CATALOG_ROLLBACK=false so no dup tests are needed.
Just want to double confirm :)
ContributorAuthor
There was a problem hiding this comment.
Thanks @yanxinyi , I think there are tests related to ALLOW_SPLITTABLE_SYSTEM_CATALOG_ROLLBACK=false (default value) but CANNOT_MUTATE_TABLE error code is not tested for table and view both. Also, without this source code change, this test will fail because we don't have coverage for View. Hence, thought of writing it separately to cover all 4 cases together: add/delete and table/view.
Hence, I think for false value of ALLOW_SPLITTABLE_SYSTEM_CATALOG_ROLLBACK, we don't need additional test :)
Sounds good?
stoty
commented
Oct 20, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.