PHOENIX-6178 Consider adopting the create-release scripts and process… by stoty · Pull Request #918 · apache/phoenix

stoty · 2020-10-13T08:55:04Z

… from HBase

copy and adapt dev/create-release from HBase
remove source assembly
add binary lincenses to binary assembly

stoty · 2020-10-13T13:01:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	36m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	3m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	39m 52s	master passed
+1 💚	compile	1m 45s	master passed
+1 💚	javadoc	1m 30s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	46m 34s	the patch passed
+1 💚	compile	1m 36s	the patch passed
+1 💚	javac	1m 36s	the patch passed
+1 💚	hadolint	0m 2s	There were no new hadolint issues.
-1 ❌	shellcheck	0m 10s	The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
-1 ❌	shelldocs	0m 2s	The patch generated 76 new + 0 unchanged - 0 fixed = 76 total (was 0)
-1 ❌	whitespace	0m 1s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	xml	0m 5s	The patch has no ill-formed XML file.
+1 💚	javadoc	1m 31s	the patch passed
		_ Other Tests _
-1 ❌	unit	109m 31s	root in the patch failed.
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		245m 46s

Reason	Tests
Failed junit tests	phoenix.end2end.OrphanViewToolIT
	phoenix.end2end.UpsertSelectIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#918
Optional Tests	dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile
uname	Linux 9d4846a0e3d3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `4b2ff49`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
shellcheck	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
shelldocs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/artifact/yetus-general-check/output/diff-patch-shelldocs.txt
whitespace	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/artifact/yetus-general-check/output/whitespace-eol.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/testReport/
Max. process+thread count	6704 (vs. ulimit of 30000)
modules	C: phoenix-assembly . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.7.0 hadolint=1.17.5-0-g443423c
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser

I assume you've been trying this out locally? Do you have a staged released that I could take a look at (just to make sure it's generating something "sane" looking?

Otherwise, just nitpicking on docs and copy-paste stuff.

stoty · 2020-10-14T05:49:49Z

Extended the docs, improved version detection heuristics, and fixed references in email template.

stoty · 2020-10-14T05:51:18Z

I will soon release rc0 for thirdparty with the script.

… from HBase * copy and adapt dev/create-release from HBase * remove source assembly * add binary lincenses to binary assembly * use assembly as binary distribution

stoty · 2020-10-26T08:37:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	3m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	11m 26s	master passed
+1 💚	compile	1m 22s	master passed
-1 ❌	javadoc	0m 9s	phoenix-assembly in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	8m 59s	the patch passed
+1 💚	compile	1m 23s	the patch passed
+1 💚	javac	1m 23s	the patch passed
+1 💚	hadolint	0m 2s	There were no new hadolint issues.
-1 ❌	shellcheck	0m 9s	The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
-1 ❌	shelldocs	0m 2s	The patch generated 76 new + 0 unchanged - 0 fixed = 76 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 4s	The patch has no ill-formed XML file.
-1 ❌	javadoc	0m 7s	phoenix-assembly in the patch failed.
		_ Other Tests _
-1 ❌	unit	157m 52s	root in the patch failed.
+1 💚	asflicense	0m 40s	The patch does not generate ASF License warnings.
		191m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#918
Optional Tests	dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile
uname	Linux 97732382b2cd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 46779eb
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
javadoc	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/2/artifact/yetus-general-check/output/branch-javadoc-phoenix-assembly.txt
shellcheck	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/2/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
shelldocs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/2/artifact/yetus-general-check/output/diff-patch-shelldocs.txt
javadoc	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/2/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/2/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/2/testReport/
Max. process+thread count	6043 (vs. ulimit of 30000)
modules	C: phoenix-assembly . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/2/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.7.0 hadolint=1.17.5-0-g443423c
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2020-10-26T10:57:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	3m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	10m 4s	master passed
+1 💚	compile	1m 21s	master passed
-1 ❌	javadoc	0m 10s	phoenix-assembly in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	7m 55s	the patch passed
+1 💚	compile	1m 20s	the patch passed
+1 💚	javac	1m 20s	the patch passed
+1 💚	hadolint	0m 1s	There were no new hadolint issues.
-1 ❌	shellcheck	0m 9s	The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
-1 ❌	shelldocs	0m 1s	The patch generated 76 new + 0 unchanged - 0 fixed = 76 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 4s	The patch has no ill-formed XML file.
-1 ❌	javadoc	0m 7s	phoenix-assembly in the patch failed.
		_ Other Tests _
-1 ❌	unit	102m 46s	root in the patch failed.
+1 💚	asflicense	0m 49s	The patch does not generate ASF License warnings.
		138m 43s

Reason	Tests
Failed junit tests	phoenix.end2end.TableSnapshotReadsMapReduceIT
	phoenix.end2end.OrphanViewToolIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#918
Optional Tests	dupname asflicense shellcheck shelldocs hadolint javac javadoc unit xml compile
uname	Linux 0c8f02e41520 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 46779eb
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
javadoc	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/3/artifact/yetus-general-check/output/branch-javadoc-phoenix-assembly.txt
shellcheck	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/3/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
shelldocs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/3/artifact/yetus-general-check/output/diff-patch-shelldocs.txt
javadoc	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/3/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/3/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/3/testReport/
Max. process+thread count	6783 (vs. ulimit of 30000)
modules	C: phoenix-assembly . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/3/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.7.0 hadolint=1.17.5-0-g443423c
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser

Let's try it out!

Good catch on the RAT exclusions (thought I caught something you missed, but then I saw the exclusions at the very bottom!)

stoty requested review from ChinmaySKulkarni, ankitsinghal and joshelser October 13, 2020 08:55

stoty force-pushed the PHOENIX-6178 branch from 1e9c5f4 to 52737e1Compare October 13, 2020 14:39

joshelser reviewed Oct 14, 2020
View reviewed changes

Comment threaddev/create-release/do-release-docker.sh

joshelser requested changes Oct 14, 2020
View reviewed changes

stoty force-pushed the PHOENIX-6178 branch from 744d830 to c071ac1Compare October 26, 2020 05:25

PHOENIX-6178 Consider adopting the create-release scripts and process…
87981d8
… from HBase * copy and adapt dev/create-release from HBase * remove source assembly * add binary lincenses to binary assembly * use assembly as binary distribution

stoty force-pushed the PHOENIX-6178 branch from c071ac1 to 87981d8Compare October 26, 2020 05:34

joshelser approved these changes Oct 26, 2020
View reviewed changes

stoty closed this Oct 27, 2020

stoty deleted the PHOENIX-6178 branch July 29, 2021 12:39

Navigation Menu

Uh oh!

PHOENIX-6178 Consider adopting the create-release scripts and process… - #918

PHOENIX-6178 Consider adopting the create-release scripts and process…#918
stoty wants to merge 1 commit into
apache:masterfrom
stoty:PHOENIX-6178

stoty commented Oct 13, 2020

Uh oh!

stoty commented Oct 13, 2020

Uh oh!

Uh oh!

joshelser left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stoty commented Oct 14, 2020

Uh oh!

stoty commented Oct 14, 2020

Uh oh!

stoty commented Oct 26, 2020

Uh oh!

stoty commented Oct 26, 2020

Uh oh!

joshelser left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

stoty commented Oct 13, 2020

Uh oh!

stoty commented Oct 13, 2020

Uh oh!

Uh oh!

joshelser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stoty commented Oct 14, 2020

Uh oh!

stoty commented Oct 14, 2020

Uh oh!

stoty commented Oct 26, 2020

Uh oh!

stoty commented Oct 26, 2020

Uh oh!

joshelser left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants