Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6185 : Propagate info available in SQLExceptionInfo to SQLTimeoutException - #919
Merged
Conversation
stoty
commented
Oct 13, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
virajjasani
commented
Oct 14, 2020
ContributorAuthor
It's strange that build data is not available on ci-hadoop. Perhaps some clearn up took place? |
virajjasani
commented
Oct 14, 2020
ContributorAuthor
|
stoty
commented
Oct 15, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
virajjasani
commented
Oct 15, 2020
ContributorAuthor
@gjacoby126 checkstyle is fixed, should be visible in next build. This applies directly to 4.x. Would you like me to create 4.x PR? |
Uh oh!
There was an error while loading. Please reload this page.
shahrs87
requested changes
Oct 15, 2020
shahrs87
left a comment
Contributor
There was a problem hiding this comment.
just 1 minor comment. other than ltgm.
| (info.getMessage() != null ? info.getMessage() : "") | ||
| + (info.getRootCause() != null ? " , rootCause: " | ||
| + info.getRootCause() : ""); | ||
| return new SQLTimeoutException(reason, |
Contributor
There was a problem hiding this comment.
Sorry missed this in my previous review.
If there is root cause exception present, you should use this constructor to create SQLtimeoutException
public SQLTimeoutException(String reason,
String SQLState,
int vendorCode,
Throwable cause)
| assertEquals(OPERATION_TIMED_OUT.getErrorCode(), | ||
| e.getErrorCode()); | ||
| assertTrue(e.getMessage().contains("Query couldn't be " + | ||
| "completed in the allotted time: 5000 ms")); |
Contributor
There was a problem hiding this comment.
Should we check that e.getCause() != null ?
ContributorAuthor
There was a problem hiding this comment.
Actually it is null in this case because for the test, rootCause is not provided here (BaseResultIterators):
throw new SQLExceptionInfo.Builder(OPERATION_TIMED_OUT).setMessage(
". Query couldn't be completed in the allotted time: "
+ queryTimeOut + " ms").build().buildException();
However, I tested by manually adding rootCause and receiving on test side. Hence, it is working fine but since relevant source code does not add root cause, e.getCause() != null would not be true here.
Contributor
There was a problem hiding this comment.
@virajjasani Can we just write a unit test creating OPERATION_TIMED_OUT exception with custom message and custom fake exception. Ideally we wouldn't even need integration test but the test that you wrote is very nice.
ContributorAuthor
There was a problem hiding this comment.
Done. Let's keep both unit and IT.
Thanks
stoty
commented
Oct 15, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
shahrs87
approved these changes
Oct 15, 2020
Contributor
There was a problem hiding this comment.
+1 ltgm pending jenkins run. Thank you @virajjasani for fixing nitty comments. :)
stoty
commented
Oct 15, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126 pushed a commit
that referenced
this pull request
Oct 16, 2020
…eoutException (#919) PHOENIX-6185 : Propagate info available in SQLExceptionInfo to OPERATION_TIMED_OUT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.