PHOENIX-6189 DATA_EXCEEDS_MAX_CAPACITY exception error string should … by yanxinyi · Pull Request #924 · apache/phoenix

yanxinyi · 2020-10-15T23:15:06Z

…contain column name instead of actual value

stoty · 2020-10-16T03:45:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 16s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	33m 43s	4.x passed
+1 💚	compile	1m 7s	4.x passed
+1 💚	checkstyle	0m 51s	4.x passed
+1 💚	javadoc	0m 54s	4.x passed
+0 🆗	spotbugs	3m 48s	phoenix-core in 4.x has 956 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	30m 15s	the patch passed
+1 💚	compile	1m 13s	the patch passed
+1 💚	javac	1m 13s	the patch passed
-1 ❌	checkstyle	0m 53s	phoenix-core: The patch generated 18 new + 1110 unchanged - 14 fixed = 1128 total (was 1124)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 52s	the patch passed
+1 💚	spotbugs	3m 53s	the patch passed
		_ Other Tests _
-1 ❌	unit	182m 22s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 31s	The patch does not generate ASF License warnings.
		269m 20s

Reason	Tests
Failed junit tests	phoenix.rpc.PhoenixClientRpcIT
	phoenix.end2end.index.ImmutableIndexExtendedIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-924/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#924
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux c68e06ad496a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `264310b`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-924/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-924/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-924/1/testReport/
Max. process+thread count	5658 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-924/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ntshmah · 2020-10-17T00:46:36Z

+
+ @Deprecated
 public DataExceedsCapacityException(PDataType type, Integer precision, Integer scale) {
 this(type, precision, scale, null, null);


You would also want to change this to call the new constructor: this(type, precision, scale, null) since this will be deprecated.

ntshmah · 2020-10-17T00:47:05Z

 }
 if (result == null) {
- throw new DataExceedsCapacityException(PDecimal.INSTANCE, maxLength, scale);
+ throw new DataExceedsCapacityException("", maxLength);


The type information could be useful here, and below too.

ntshmah

Some comments discussed offline too.

stoty · 2020-10-17T01:07:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	33m 15s	4.x passed
+1 💚	compile	1m 7s	4.x passed
+1 💚	checkstyle	1m 32s	4.x passed
+1 💚	javadoc	0m 54s	4.x passed
+0 🆗	spotbugs	3m 33s	phoenix-core in 4.x has 956 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	29m 31s	the patch passed
+1 💚	compile	1m 8s	the patch passed
+1 💚	javac	1m 8s	the patch passed
-1 ❌	checkstyle	1m 30s	phoenix-core: The patch generated 18 new + 3423 unchanged - 23 fixed = 3441 total (was 3446)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 53s	the patch passed
+1 💚	spotbugs	3m 51s	the patch passed
		_ Other Tests _
-1 ❌	unit	183m 51s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		265m 29s

Reason	Tests
Failed junit tests	phoenix.end2end.AbsFunctionEnd2EndIT
	phoenix.end2end.IndexToolForNonTxGlobalIndexIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-924/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#924
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux ebfb891a5b3e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `2359f54`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-924/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-924/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-924/2/testReport/
Max. process+thread count	5864 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-924/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…contain column name instead of actual value

ntshmah

Few nits. +1 otherwise.

ntshmah reviewed Oct 16, 2020
View reviewed changes

Comment threadphoenix-core/src/test/java/org/apache/phoenix/schema/MutationTest.java

yanxinyi force-pushed the PHOENIX-6189 branch from b2c33ff to 674aaddCompare October 16, 2020 20:41

ntshmah reviewed Oct 17, 2020
View reviewed changes

Comment threadphoenix-core/src/main/java/org/apache/phoenix/exception/DataExceedsCapacityException.java

ntshmah reviewed Oct 17, 2020
View reviewed changes

Comment threadphoenix-core/src/main/java/org/apache/phoenix/exception/DataExceedsCapacityException.java

ntshmah reviewed Oct 17, 2020
View reviewed changes

PHOENIX-6189 DATA_EXCEEDS_MAX_CAPACITY exception error string should …
77b6b08
…contain column name instead of actual value

yanxinyi force-pushed the PHOENIX-6189 branch from 674aadd to 77b6b08Compare October 17, 2020 02:36

ntshmah reviewed Oct 19, 2020
View reviewed changes

Comment threadphoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertSelectIT.java

ntshmah reviewed Oct 19, 2020
View reviewed changes

Comment threadphoenix-core/src/test/java/org/apache/phoenix/schema/MutationTest.java

ntshmah reviewed Oct 19, 2020
View reviewed changes

Comment threadphoenix-core/src/test/java/org/apache/phoenix/schema/MutationTest.java

ntshmah approved these changes Oct 19, 2020
View reviewed changes

yanxinyi closed this Oct 21, 2020

Navigation Menu

Uh oh!

PHOENIX-6189 DATA_EXCEEDS_MAX_CAPACITY exception error string should … - #924

PHOENIX-6189 DATA_EXCEEDS_MAX_CAPACITY exception error string should …#924
yanxinyi wants to merge 1 commit into
apache:4.xfrom
yanxinyi:PHOENIX-6189

yanxinyi commented Oct 15, 2020

Uh oh!

Uh oh!

stoty commented Oct 16, 2020

Uh oh!

Uh oh!

Uh oh!

ntshmahOct 17, 2020

Uh oh!

ntshmahOct 17, 2020•
edited
Loading

Uh oh!

ntshmah left a comment

Uh oh!

stoty commented Oct 17, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntshmah left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

yanxinyi commented Oct 15, 2020

Uh oh!

Uh oh!

stoty commented Oct 16, 2020

Uh oh!

Uh oh!

Uh oh!

ntshmahOct 17, 2020

Choose a reason for hiding this comment

Uh oh!

ntshmahOct 17, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ntshmah left a comment

Choose a reason for hiding this comment

Uh oh!

stoty commented Oct 17, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ntshmah left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ntshmahOct 17, 2020•
edited
Loading