Skip to content

PHOENIX-6193 PHOENIX-6151 slows down shading#925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stoty wants to merge 1 commit into from
Closed

PHOENIX-6193 PHOENIX-6151 slows down shading #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -75,7 +75,7 @@ pipeline {
checkout scm
sh """#!/bin/bash
ulimit -a
mvn clean verify -Dhbase.profile=${HBASE_PROFILE} -B
mvn clean verify -Dskip.embedded -Dhbase.profile=${HBASE_PROFILE} -B
"""
}
}
Expand Down
2 changes: 1 addition & 1 deletion dev/phoenix-personality.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -140,7 +140,7 @@ function personality_modules

# Running with threads>1 seems to trigger some problem in the build, but since we
# spend 80+% of the time in phoenix-core, it wouldn't help much anyway
extra="--threads=1 -DPhoenixPatchProcess"
extra="--threads=1 -DPhoenixPatchProcess -Dskip.embedded"
if [[ "${PATCH_BRANCH}" = 4* ]]; then
extra="${extra} -Dhttps.protocols=TLSv1.2"
fi
Expand Down
2 changes: 1 addition & 1 deletion phoenix-assembly/pom.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,7 +49,7 @@
</goals>
<configuration>
<executable>ln</executable>
<workingDirectory>${project.basedir}/../phoenix-client/target</workingDirectory>
<workingDirectory>${project.basedir}/../phoenix-client-parent/phoenix-client/target</workingDirectory>
<arguments>
<argument>-fnsv</argument>
<argument>
Expand Down
4 changes: 1 addition & 3 deletions phoenix-assembly/src/build/components/all-common-jars.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,19 +24,17 @@
<!-- Add the client & mapreduce jars. Expects the client jar packaging phase to already be run,
which is determined by specification order in the pom. -->
<fileSet>
<directory>${project.basedir}/../phoenix-client/target</directory>
<directory>${project.basedir}/../phoenix-client-parent/phoenix-client/target</directory>
<outputDirectory>/</outputDirectory>
<includes>
<include>phoenix-client-${project.version}.jar</include>
<include>phoenix-client.jar</include>
</includes>
</fileSet>
<fileSet>
<directory>${project.basedir}/../phoenix-server/target</directory>
<outputDirectory>/</outputDirectory>
<includes>
<include>phoenix-server-${project.version}.jar</include>
<include>phoenix-server.jar</include>
</includes>
</fileSet>

Expand Down
66 changes: 66 additions & 0 deletions phoenix-client-parent/phoenix-client-embedded/pom.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.phoenix</groupId>
<artifactId>phoenix-client-parent</artifactId>
<version>5.1.0-SNAPSHOT</version>
</parent>
<artifactId>phoenix-client-embedded</artifactId>
<name>Phoenix Client Embedded</name>
<description>Phoenix Client without logging implementation</description>
<packaging>jar</packaging>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
<id>embedded-shaded</id>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<shadeTestJar>false</shadeTestJar>
<createSourcesJar>true</createSourcesJar>
<dependencyReducedPomLocation>${basedir}/target/pom.xml</dependencyReducedPomLocation>
<artifactSet>
<includes>
<include>*:*</include>
</includes>
<excludes>
<exclude>org.apache.phoenix:phoenix-client</exclude>
<exclude>xom:xom</exclude>
<exclude>org.slf4j:slf4j-log4j12</exclude>
</excludes>
</artifactSet>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

</project>
66 changes: 66 additions & 0 deletions phoenix-client-parent/phoenix-client/pom.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.phoenix</groupId>
<artifactId>phoenix-client-parent</artifactId>
<version>5.1.0-SNAPSHOT</version>
</parent>
<artifactId>phoenix-client</artifactId>
<name>Phoenix Client</name>
<description>Phoenix Client</description>
<packaging>jar</packaging>

<build>
<plugins>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<executions>
<execution>
<id>default-shaded</id>
<phase>package</phase>
<goals>
<goal>shade</goal>
</goals>
<configuration>
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
<shadeTestJar>false</shadeTestJar>
<createSourcesJar>true</createSourcesJar>
<dependencyReducedPomLocation>${basedir}/target/pom.xml</dependencyReducedPomLocation>
<artifactSet>
<includes>
<include>*:*</include>
</includes>
<excludes>
<exclude>org.apache.phoenix:phoenix-client</exclude>
<exclude>xom:xom</exclude>
</excludes>
</artifactSet>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

</project>
Loading