Skip to content

PHOENIX-6194 : Include slf4j-api dependency in phoenix-tools - #926

Closed
virajjasani wants to merge 1 commit into
apache:masterfrom
virajjasani:PHOENIX-6194-master
Closed

PHOENIX-6194 : Include slf4j-api dependency in phoenix-tools#926
virajjasani wants to merge 1 commit into
apache:masterfrom
virajjasani:PHOENIX-6194-master

Conversation

@virajjasani

Copy link
Copy Markdown
Contributor

No description provided.

@virajjasani

Copy link
Copy Markdown
ContributorAuthor

@stoty could you please take a look?

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 ❌mvninstall37m 30sroot in master failed.
+1 💚compile0m 30smaster passed
+1 💚javadoc0m 16smaster passed
_ Patch Compile Tests _
+1 💚mvninstall40m 28sthe patch passed
+1 💚compile0m 33sthe patch passed
+1 💚javac0m 33sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+1 💚javadoc0m 15sthe patch passed
_ Other Tests _
+1 💚unit3m 0sphoenix-tools in the patch passed.
+1 💚asflicense0m 9sThe patch does not generate ASF License warnings.
83m 50s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-926/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#926
Optional Testsdupname asflicense javac javadoc unit xml compile
unameLinux f3ad6d8bb78f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 1784848
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-926/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-926/1/testReport/
Max. process+thread count579 (vs. ulimit of 30000)
modulesC: phoenix-tools U: phoenix-tools
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-926/1/console
versionsgit=2.7.4 maven=3.3.9
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani

Copy link
Copy Markdown
ContributorAuthor

mvninstall for patch is +1

@stotystoty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@stotystoty closed this Oct 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@virajjasani@stoty