Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6197 AggregateIT and StoreNullsIT hangs - #933
Closed
richardantal wants to merge 3 commits into
Closed
Conversation
stoty
reviewed
Oct 21, 2020
| // In this class we depend on the major compaction to be done instantly | ||
| // so wo are overwriting the PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY to 0 | ||
| @BeforeClass |
Contributor
There was a problem hiding this comment.
I would expect the change in TestUtil to fix this case as well.
Why do we need to override PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY here ?
ContributorAuthor
There was a problem hiding this comment.
My change in TestUtil solves the hanging tests, because there we waited until a put and delete is deleted, which never happened because they were just done before calling the major compaction with a PHOENIX_MAX_LOOKBACK_AGE of an hour.
In StoreNullsIT in testDeletes, we upsert a line into a table, delete it run the major compaction.
Then open a historical connection after the upsert but before the delete, previously when PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY was set to 0 we could not read back the data, but if it is set to an hour, the major compaction will not delete that. So the test would fail.
ContributorAuthor
There was a problem hiding this comment.
But the comment here is not accurate, thats right.
stoty
reviewed
Oct 21, 2020
Uh oh!
There was an error while loading. Please reload this page.
stoty
commented
Oct 21, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
richardantalforce-pushed
the
PHOENIX-6197
branch
from
October 22, 2020 10:10
cd92fb4 to
dc6e882Comparestoty
commented
Oct 22, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126
approved these changes
Oct 22, 2020
gjacoby126
left a comment
Contributor
There was a problem hiding this comment.
+1, thanks for tracking this down.
| Put put = new Put(markerRowKey); | ||
| put.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES, QueryConstants.EMPTY_COLUMN_VALUE_BYTES, QueryConstants.EMPTY_COLUMN_VALUE_BYTES); | ||
| long timestamp = 0; |
stoty
commented
Oct 23, 2020
Contributor
Addressed Geoffrey's NIT, and committed to fix the build ASAP. |
stoty
commented
Oct 23, 2020
Contributor
StoreNullsIT fails when running as part of the full IT suite. |
Contributor
Opened a PR for the addendum at #939 so that the precommit tests get executed on it. |
gjacoby126
commented
Nov 20, 2020
Contributor
JIRA is resolved, closing PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.