Skip to content

PHOENIX-6087 : Resolve Phoenix Connection leak in UpgradeUtil.addViewIndexToParentLinks() and Admin leak in UpgradeUtil.syncTableAndIndexProperties() - #943

Closed
virajjasani wants to merge 2 commits into
apache:masterfrom
virajjasani:PHOENIX-6087-master
Closed

PHOENIX-6087 : Resolve Phoenix Connection leak in UpgradeUtil.addViewIndexToParentLinks() and Admin leak in UpgradeUtil.syncTableAndIndexProperties()#943
virajjasani wants to merge 2 commits into
apache:masterfrom
virajjasani:PHOENIX-6087-master

Conversation

@virajjasani

@virajjasanivirajjasani commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@virajjasanivirajjasani changed the title PHOENIX-6087 : Resolved Phoenix Connection leak in UpgradeUtil.addViewIndexToParentLinks() and Admin leak in UpgradeUtil.syncTableAndIndexProperties()PHOENIX-6087 : Resolve Phoenix Connection leak in UpgradeUtil.addViewIndexToParentLinks() and Admin leak in UpgradeUtil.syncTableAndIndexProperties()Oct 28, 2020
@stoty

stoty commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall14m 12smaster passed
+1 💚compile1m 3smaster passed
+1 💚checkstyle1m 27smaster passed
+1 💚javadoc0m 47smaster passed
+0 🆗spotbugs3m 11sphoenix-core in master has 969 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall8m 52sthe patch passed
+1 💚compile0m 58sthe patch passed
+1 💚javac0m 58sthe patch passed
-1 ❌checkstyle1m 29sphoenix-core: The patch generated 44 new + 3460 unchanged - 67 fixed = 3504 total (was 3527)
-1 ❌whitespace0m 0sThe patch 1 line(s) with tabs.
+1 💚javadoc0m 45sthe patch passed
+1 💚spotbugs3m 18sthe patch passed
_ Other Tests _
-1 ❌unit159m 42sphoenix-core in the patch failed.
+1 💚asflicense0m 26sThe patch does not generate ASF License warnings.
199m 45s
ReasonTests
Failed junit testsphoenix.end2end.salted.SaltedTableVarLengthRowKeyIT
phoenix.end2end.UpsertSelectIT
phoenix.end2end.index.IndexMetadataIT
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#943
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux c5ecfed6ca82 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 6d84d0f
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
whitespacehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/1/artifact/yetus-general-check/output/whitespace-tabs.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/1/testReport/
Max. process+thread count6288 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
PHOENIX-6087: Resolved Phoenix Connection leak in UpgradeUtil.addVie…
36c7616
…wIndexToParentLinks() and Admin leak in UpgradeUtil.syncTableAndIndexProperties()
@stoty

stoty commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall14m 32smaster passed
+1 💚compile1m 2smaster passed
+1 💚checkstyle1m 28smaster passed
+1 💚javadoc0m 48smaster passed
+0 🆗spotbugs3m 12sphoenix-core in master has 969 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall9m 10sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
-1 ❌checkstyle1m 28sphoenix-core: The patch generated 6 new + 3497 unchanged - 30 fixed = 3503 total (was 3527)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 45sthe patch passed
+1 💚spotbugs3m 19sthe patch passed
_ Other Tests _
-1 ❌unit156m 58sphoenix-core in the patch failed.
+1 💚asflicense0m 23sThe patch does not generate ASF License warnings.
197m 41s
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#943
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux b1169786098f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 6d84d0f
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/2/testReport/
Max. process+thread count6158 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

yanxinyi
yanxinyi reviewed Oct 30, 2020
View reviewed changes
Comment threadphoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java Outdated
// metaConn eligible for closure
isMetaConnUsingQueryConn = false;
}
String schemaName = rs.getString("TABLE_SCHEM");

@yanxinyiyanxinyiOct 30, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please using PhoenixDatabaseMetaData.TABLE_SCHEM constant

@stoty

stoty commented Oct 30, 2020

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 47sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
-1 ❌test4tests0m 0sThe patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚mvninstall14m 28smaster passed
+1 💚compile1m 4smaster passed
+1 💚checkstyle1m 28smaster passed
+1 💚javadoc0m 48smaster passed
+0 🆗spotbugs3m 10sphoenix-core in master has 969 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall9m 10sthe patch passed
+1 💚compile0m 56sthe patch passed
+1 💚javac0m 56sthe patch passed
-1 ❌checkstyle1m 28sphoenix-core: The patch generated 43 new + 3460 unchanged - 67 fixed = 3503 total (was 3527)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 46sthe patch passed
+1 💚spotbugs3m 19sthe patch passed
_ Other Tests _
-1 ❌unit166m 12sphoenix-core in the patch failed.
+1 💚asflicense0m 22sThe patch does not generate ASF License warnings.
212m 28s
ReasonTests
Failed junit testsphoenix.end2end.join.SubqueryUsingSortMergeJoinIT
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#943
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux e0cb7cd78afa 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / ff46e35
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/3/testReport/
Max. process+thread count6365 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-943/3/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

yanxinyi
yanxinyi approved these changes Oct 30, 2020
View reviewed changes

@yanxinyiyanxinyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@virajjasani thank you for the contribution

@virajjasani
virajjasani deleted the PHOENIX-6087-master branch November 6, 2020 06:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanxinyiyanxinyiyanxinyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@virajjasani@stoty@yanxinyi