PHOENIX-6002 : Resolve connection leak through QueryUtil.getConnectionOnServer()

[virajjasani]

No description provided.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	12m 39s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	checkstyle	1m 17s	master passed
+1 💚	javadoc	0m 45s	master passed
+0 🆗	spotbugs	2m 57s	phoenix-core in master has 969 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 20s	the patch passed
+1 💚	compile	0m 52s	the patch passed
+1 💚	javac	0m 52s	the patch passed
-1 ❌	checkstyle	1m 20s	phoenix-core: The patch generated 8 new + 1954 unchanged - 21 fixed = 1962 total (was 1975)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 42s	the patch passed
+1 💚	spotbugs	3m 1s	the patch passed
		_ Other Tests _
-1 ❌	unit	101m 17s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 24s	The patch does not generate ASF License warnings.
		140m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-946/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#946
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 1e0bebb6604d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / ff46e35
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-946/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-946/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-946/1/testReport/
Max. process+thread count	6806 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-946/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[virajjasani]

Thanks for the review @yanxinyi , I have uploaded both master and 4.x patches on Jira.