Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-5895: Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table - #951
Merged
Conversation
ContributorAuthor
@gjacoby126 can you please review this? |
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
Nice idea to leverage WALCellFilter
Uh oh!
There was an error while loading. Please reload this page.
| return isTenantRowCell(cell) ? cell : null; | ||
| } | ||
| private boolean isTenantRowCell(Cell cell) { |
Contributor
There was a problem hiding this comment.
Not related to this changes, but wondering if we need to construct ImmutableBytesWritable object.
Can this method impl be reduced to:
return cell.getRowArray()[cell.getRowOffset()] != QueryConstants.SEPARATOR_BYTE;
Contributor
There was a problem hiding this comment.
@virajjasani - yes, I believe that will work. ImmutableBytesWritable.get() just returns the underlying byte array
ContributorAuthor
There was a problem hiding this comment.
yes, it should be same, I will change that
publicbyte [] get() {
if (this.bytes == null) {
thrownewIllegalStateException("Uninitialiized. Null constructor " +
"called w/o accompaying readFields invocation");
}
returnthis.bytes;
}| import org.apache.hadoop.hbase.replication.WALCellFilter; | ||
| import org.apache.hadoop.hbase.replication.WALEntryFilter; | ||
| import org.apache.hadoop.hbase.wal.WAL; | ||
| import org.apache.phoenix.query.QueryConstants; |
Contributor
There was a problem hiding this comment.
nit: we can get rid of List and Lists imports
stoty
commented
Nov 2, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126
approved these changes
Nov 2, 2020
gjacoby126
left a comment
Contributor
There was a problem hiding this comment.
+1, thanks @sandeepvinayak
| return isTenantRowCell(cell) ? cell : null; | ||
| } | ||
| private boolean isTenantRowCell(Cell cell) { |
Contributor
There was a problem hiding this comment.
@virajjasani - yes, I believe that will work. ImmutableBytesWritable.get() just returns the underlying byte array
Uh oh!
There was an error while loading. Please reload this page.
sandeepvinayakforce-pushed
the
PHOENIX-5895-master
branch
from
November 4, 2020 07:39
58d8813 to
2373aa8Comparestoty
commented
Nov 4, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Nov 4, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
ChinmaySKulkarni
approved these changes
Nov 10, 2020
ankitjain64
approved these changes
Nov 11, 2020
ankitjain64
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sandeepvinayak .
gjacoby126
commented
Nov 11, 2020
Contributor
@sandeepvinayak - could you please rename the commit to include the JIRA number? (Might as well squash while you're rebasing too.) Then I'll commit. |
sandeepvinayakforce-pushed
the
PHOENIX-5895-master
branch
from
November 12, 2020 00:08
2373aa8 to
5eee635Compare
…r to replicate system catalog table
sandeepvinayakforce-pushed
the
PHOENIX-5895-master
branch
from
November 12, 2020 00:11
5eee635 to
eb8ff61Comparegjacoby126
commented
Nov 12, 2020
Contributor
Thanks, @sandeepvinayak |
stoty
commented
Nov 12, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.