Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam… - #953
Closed
richardantal wants to merge 1 commit into
Closed
PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…#953richardantal wants to merge 1 commit into
richardantal wants to merge 1 commit into
Conversation
stoty
commented
Nov 2, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126
commented
Nov 2, 2020
Contributor
Change itself looks good, @richardantal , but could we please have a simple test? |
richardantalforce-pushed
the
PHOENIX-6091
branch
from
November 3, 2020 08:51
db061ae to
d5c40acComparerichardantal
commented
Nov 3, 2020
ContributorAuthor
Thanks @gjacoby126 for the review. |
virajjasani
left a comment
Contributor
There was a problem hiding this comment.
Left one minor comment, looks good otherwise
| long serversTimstamp = System.currentTimeMillis(); | ||
| String version = MetaDataProtocol.getVersion(serversTimstamp); | ||
| assertEquals("4.16.x", version); // We have to update it after every release | ||
| assertEquals(String.format("%d.%d.%s", PHOENIX_MAJOR_VERSION, PHOENIX_MINOR_VERSION, "x"), |
Contributor
There was a problem hiding this comment.
I believe this assert might be better fit for all branches and the one above assertEquals("4.16.x", version); might not be needed. Thought?
ContributorAuthor
There was a problem hiding this comment.
Yeah, that is right!
…p gives version as 4.15.x
richardantalforce-pushed
the
PHOENIX-6091
branch
from
November 3, 2020 11:58
d5c40ac to
2f68a3dComparevirajjasani
approved these changes
Nov 3, 2020
stoty
commented
Nov 3, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…p gives version as 4.15.x