Skip to content

PHOENIX-6212: Improve SystemCatalogIT.testSystemTableSplit() to ensure no splitting occurs when splitting is disabled - #962

Merged
ChinmaySKulkarni merged 1 commit into
apache:4.xfrom
ChinmaySKulkarni:PHOENIX-6212
Nov 11, 2020
Merged

PHOENIX-6212: Improve SystemCatalogIT.testSystemTableSplit() to ensure no splitting occurs when splitting is disabled#962
ChinmaySKulkarni merged 1 commit into
apache:4.xfrom
ChinmaySKulkarni:PHOENIX-6212

Conversation

@ChinmaySKulkarni

Copy link
Copy Markdown
Contributor

No description provided.

}
}
assertTrue("No region servers available to move regions on to ", !availableRegionServers.isEmpty());
assertFalse("No region servers available to move regions on to ",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like assertFalse here and remove !

@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 55sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ 4.x Compile Tests _
+1 💚mvninstall13m 2s4.x passed
+1 💚compile1m 17s4.x passed
+1 💚checkstyle0m 36s4.x passed
+1 💚javadoc0m 50s4.x passed
+0 🆗spotbugs3m 50sphoenix-core in 4.x has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall7m 19sthe patch passed
+1 💚compile1m 12sthe patch passed
+1 💚javac1m 12sthe patch passed
+1 💚checkstyle0m 35sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 55sthe patch passed
+1 💚spotbugs3m 58sthe patch passed
_ Other Tests _
-1 ❌unit190m 39sphoenix-core in the patch failed.
+1 💚asflicense0m 30sThe patch does not generate ASF License warnings.
229m 9s
ReasonTests
Failed junit testsphoenix.end2end.AlterTableIT
phoenix.end2end.index.MutableIndexReplicationIT
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#962
JIRA IssuePHOENIX-6212
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 4dac62f879c9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / 21e729f
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/1/testReport/
Max. process+thread count6088 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…e no splitting occurs when splitting is disabled
@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec5m 58sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ 4.x Compile Tests _
+1 💚mvninstall10m 50s4.x passed
+1 💚compile0m 55s4.x passed
+1 💚checkstyle0m 29s4.x passed
+1 💚javadoc0m 45s4.x passed
+0 🆗spotbugs2m 54sphoenix-core in 4.x has 946 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall5m 14sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚checkstyle0m 29sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 43sthe patch passed
+1 💚spotbugs3m 1sthe patch passed
_ Other Tests _
-1 ❌unit137m 39sphoenix-core in the patch failed.
+1 💚asflicense0m 40sThe patch does not generate ASF License warnings.
173m 19s
ReasonTests
Failed junit testsphoenix.end2end.index.MutableIndexSplitReverseScanIT
phoenix.end2end.PhoenixRuntimeIT
phoenix.end2end.index.GlobalMutableNonTxIndexWithLazyPostBatchWriteIT
phoenix.end2end.IndexToolForNonTxGlobalIndexIT
phoenix.end2end.DerivedTableIT
phoenix.end2end.BackwardCompatibilityIT
phoenix.end2end.UnionAllIT
phoenix.end2end.UpsertSelectIT
phoenix.util.IndexScrutinyIT
phoenix.end2end.QueryMoreIT
phoenix.end2end.RowTimestampIT
phoenix.end2end.join.SubqueryIT
SubsystemReport/Notes
DockerClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#962
JIRA IssuePHOENIX-6212
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 63166a61a9e4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / c9c80b2
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/2/testReport/
Max. process+thread count5985 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ChinmaySKulkarni
ChinmaySKulkarni merged commit 565b0ea into apache:4.xNov 11, 2020
@ChinmaySKulkarni
ChinmaySKulkarni deleted the PHOENIX-6212 branch November 11, 2020 23:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ChinmaySKulkarni@stoty@yanxinyi