Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6211 Paged scan filters - #973
Closed
kadirozde wants to merge 4 commits into
Closed
Conversation
kadirozde
requested review from
ChinmaySKulkarni, abhishek-chouhan and gjacoby126November 18, 2020 02:22
stoty
commented
Nov 18, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
kadirozde
marked this pull request as draft
November 18, 2020 08:46
stoty
commented
Nov 22, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Nov 24, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Nov 25, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Nov 26, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Nov 27, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Nov 28, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Dec 5, 2020
Contributor
stoty
commented
Dec 6, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Dec 6, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Dec 7, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
kadirozde
marked this pull request as ready for review
December 7, 2020 07:03
kadirozde
marked this pull request as draft
December 7, 2020 19:34
kadirozde
marked this pull request as ready for review
December 8, 2020 16:49
stoty
commented
Dec 9, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
| } | ||
| static boolean adjustScanFilter(Scan scan) { | ||
| // For rebuilds we use count (*) as query for regular tables which ends up setting the FKOF on scan |
Contributor
There was a problem hiding this comment.
nit: please spell out FirstKeyOnlyFilter. Took me a minute to figure it out. :-)
| } | ||
| } | ||
| @Ignore("Fails with StaleRegionBoundaryCacheException. Mutations on a SCN connection could be the reason") |
Contributor
There was a problem hiding this comment.
@jpisaac what are the implications of ignoring these tests?
Contributor
There was a problem hiding this comment.
@gjacoby126@kadirozde I have a fix for these test failures. It was failing in BaseScannerRegionObserver.preScannerOpen by throwing throwIfScanOutOfRegion when deletion of LocalIndexes are involved. All the ViewTTLIT tests are passing after the fix on my local machine
Contributor
There was a problem hiding this comment.
@jpisaac - are the test fixes already in so that @kadirozde can rebase on them, or still just local to you?
Contributor
There was a problem hiding this comment.
0001-Fixes-for-local-index-scans-and-additional-tests.patch.txt
@kadirozde@gjacoby126 I have attached the changes for the local index changes and some additional tests and added some comments on the PhoenixTTLRegionObserver
ContributorAuthor
There was a problem hiding this comment.
@jpisaac, Thank you very much. I will apply your patch soon.
| if (!(scan.getFilter() instanceof PagedFilter)) { | ||
| byte[] pageSizeMsBytes = scan.getAttribute(BaseScannerRegionObserver.SERVER_PAGE_SIZE_MS); | ||
| if (pageSizeMsBytes != null) { | ||
| scan.setFilter(new PagedFilter(scan.getFilter(), Bytes.toLong(pageSizeMsBytes)/2)); |
Contributor
There was a problem hiding this comment.
Why divided by 2? To allow for round trip time back to client? Good to have a comment.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| import org.apache.hadoop.hbase.util.Bytes; | ||
| import org.apache.phoenix.hbase.index.util.GenericKeyValueBuilder; | ||
| import org.apache.phoenix.util.PhoenixKeyValueUtil; | ||
| import org.apache.phoenix.util.ScanUtil; |
Contributor
There was a problem hiding this comment.
nit: seems like several unnecessary imports?
Uh oh!
There was an error while loading. Please reload this page.
stoty
commented
Dec 15, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126
requested changes
Dec 18, 2020
| } | ||
| private boolean next(List<Cell> results, boolean raw) throws IOException { | ||
| boolean hasMore = raw ? delegate.nextRaw(results) : delegate.next(results); |
Contributor
There was a problem hiding this comment.
if we throw an exception at either line 47 or line 56, do we clean up our state properly?
ContributorAuthor
There was a problem hiding this comment.
I will add exception handling here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
stoty
commented
Dec 21, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Dec 22, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Dec 22, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gjacoby126
commented
Jan 7, 2021
Contributor
@kadirozde - other than above comments lgtm. |
stoty
commented
Jan 7, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
gjacoby126
approved these changes
Jan 7, 2021
gjacoby126
left a comment
Contributor
There was a problem hiding this comment.
+1, thanks @kadirozde . Looks like you just need to rebase GlobalIndexChecker.
stoty
commented
Jan 8, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
stoty
commented
Jan 10, 2021
Contributor
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The design doc is at https://docs.google.com/document/d/1Vt28i9JLQPG3lAnbW3RcO7fEUG4KT5AhyydLMiau59k/edit?usp=sharing