PHOENIX-6186 - Store last DDL timestamp in System.Catalog (5.x)

[gjacoby126]

No description provided.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	3m 38s	Maven dependency ordering for branch
+1 💚	mvninstall	11m 42s	master passed
+1 💚	compile	1m 26s	master passed
+1 💚	checkstyle	7m 30s	master passed
+1 💚	javadoc	1m 58s	master passed
+0 🆗	spotbugs	3m 7s	phoenix-core in master has 965 extant spotbugs warnings.
+0 🆗	spotbugs	4m 11s	root in master has 1014 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	9m 26s	the patch passed
+1 💚	compile	1m 25s	the patch passed
+1 💚	cc	1m 25s	the patch passed
+1 💚	javac	1m 25s	the patch passed
-1 ❌	checkstyle	7m 26s	root: The patch generated 371 new + 25007 unchanged - 255 fixed = 25378 total (was 25262)
+1 💚	prototool	0m 2s	There were no new prototool issues.
-1 ❌	whitespace	0m 0s	The patch 1 line(s) with tabs.
-1 ❌	javadoc	0m 51s	phoenix-core generated 1 new + 99 unchanged - 1 fixed = 100 total (was 100)
-1 ❌	javadoc	1m 13s	root generated 1 new + 131 unchanged - 1 fixed = 132 total (was 132)
-1 ❌	spotbugs	3m 40s	phoenix-core generated 2 new + 964 unchanged - 1 fixed = 966 total (was 965)
-1 ❌	spotbugs	4m 47s	root generated 2 new + 1013 unchanged - 1 fixed = 1015 total (was 1014)
		_ Other Tests _
-1 ❌	unit	168m 43s	root in the patch failed.
+1 💚	asflicense	0m 44s	The patch does not generate ASF License warnings.
		238m 1s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 337]
	A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) At UpgradeUtil.java:[line 2616]
FindBugs	module:root
	org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 337]
	A prepared statement is generated from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) At UpgradeUtil.java:from a nonconstant String in org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) At UpgradeUtil.java:[line 2616]

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#977
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool
uname	Linux 104e3966bebc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / 2af2adf
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
whitespace	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/whitespace-tabs.txt
javadoc	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt
javadoc	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/new-spotbugs-root.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/testReport/
Max. process+thread count	6271 (vs. ulimit of 30000)
modules	C: phoenix-core . U: .
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-977/4/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[gjacoby126]

Tests passed; the failure seems to come from jacoco crashing afterward. Since this is just a port of the previously approved 4.x version of PHOENIX-6186, I'm going to go ahead and merge.