Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6082 : Avoid checkAndPut when altering properties for a table or view with column-encoding enabled - #983
Closed
virajjasani wants to merge 1 commit into
Closed
PHOENIX-6082 : Avoid checkAndPut when altering properties for a table or view with column-encoding enabled#983virajjasani wants to merge 1 commit into
virajjasani wants to merge 1 commit into
Conversation
stoty
commented
Nov 23, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
… or view with column-encoding enabled
stoty
commented
Nov 26, 2020
Contributor
💔 -1 overall
This message was automatically generated. |
ChinmaySKulkarni
approved these changes
Dec 2, 2020
ChinmaySKulkarni
left a comment
Contributor
There was a problem hiding this comment.
+1, thanks! Waiting for any other reviews before committing your changes.
Btw, the test failures look unrelated and flaky but I think we should open a Jira to fix these tests/contact INFRA if it is an infra issue (OOM, shutdowns, etc.) WDYT @virajjasani@yanxinyi@gjacoby126 ?
virajjasani
commented
Dec 3, 2020
ContributorAuthor
Sure @ChinmaySKulkarni , sounds good. Let me try to collect some of these flaky tests results and create Jira accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4.x backport of PR #982