Uh oh!
There was an error while loading. Please reload this page.
PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table#995
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -91,6 +91,11 @@ public IndexRepairRegionScanner(final RegionScanner innerScanner, | ||
| } | ||
| } | ||
| @Override | ||
| public byte[] getDataTableName() { | ||
| return dataHTable.getName().toBytes(); | ||
| } | ||
| public void prepareExpectedIndexMutations(Result dataRow, Map<byte[], List<Mutation>> expectedIndexMutationMap) throws IOException { | ||
| Put put = null; | ||
| Delete del = null; | ||
| @@ -178,6 +183,28 @@ private Map<byte[], List<Mutation>> populateActualIndexMutationMap(Map<byte[], L | ||
| return actualIndexMutationMap; | ||
| } | ||
| private Map<byte[], List<Mutation>> populateActualIndexMutationMap() throws IOException { | ||
| Map<byte[], List<Mutation>> actualIndexMutationMap = Maps.newTreeMap(Bytes.BYTES_COMPARATOR); | ||
| Scan indexScan = new Scan(); | ||
| indexScan.setTimeRange(scan.getTimeRange().getMin(), scan.getTimeRange().getMax()); | ||
| indexScan.setRaw(true); | ||
| indexScan.setMaxVersions(); | ||
| indexScan.setCacheBlocks(false); | ||
| try (RegionScanner regionScanner = region.getScanner(indexScan)) { | ||
Contributor There was a problem hiding this comment. Does the below code work if there is no index row? ContributorAuthor There was a problem hiding this comment. @gokceni I am not sure I understood your concern here ? Contributor There was a problem hiding this comment. If the index is truncated for some reason and this code is run, the below do while code, will it work since you seem to be checking the hasMore in the while part of the loop? ContributorAuthor There was a problem hiding this comment. @gokceni hasMore will be false in that case and the code should exit the loop. This is a standard pattern used in multiple places in the index rebuild code. | ||
| do { | ||
| ungroupedAggregateRegionObserver.checkForRegionClosing(); | ||
| List<Cell> row = new ArrayList<Cell>(); | ||
| hasMore = regionScanner.nextRaw(row); | ||
| if (!row.isEmpty()) { | ||
| populateIndexMutationFromIndexRow(row, actualIndexMutationMap); | ||
| } | ||
| } while (hasMore); | ||
| } catch (Throwable t) { | ||
| ServerUtil.throwIOException(region.getRegionInfo().getRegionNameAsString(), t); | ||
| } | ||
| return actualIndexMutationMap; | ||
| } | ||
| private void repairAndOrVerifyIndexRows(Set<byte[]> dataRowKeys, | ||
| Map<byte[], List<Mutation>> actualIndexMutationMap, | ||
| IndexToolVerificationResult verificationResult) throws IOException { | ||
| @@ -188,7 +215,7 @@ private void repairAndOrVerifyIndexRows(Set<byte[]> dataRowKeys, | ||
| return; | ||
| } | ||
| if (verifyType == IndexTool.IndexVerifyType.ONLY) { | ||
| verifyIndexRows(actualIndexMutationMap, expectedIndexMutationMap, Collections.EMPTY_SET, indexRowsToBeDeleted, verificationResult.getBefore(), true); | ||
| return; | ||
| } | ||
| if (verifyType == IndexTool.IndexVerifyType.BEFORE) { | ||
| @@ -200,11 +227,12 @@ private void repairAndOrVerifyIndexRows(Set<byte[]> dataRowKeys, | ||
| } | ||
| if (verifyType == IndexTool.IndexVerifyType.AFTER) { | ||
| repairIndexRows(expectedIndexMutationMap, Collections.EMPTY_LIST, verificationResult); | ||
| actualIndexMutationMap = populateActualIndexMutationMap(); | ||
| verifyIndexRows(actualIndexMutationMap, expectedIndexMutationMap, Collections.EMPTY_SET, indexRowsToBeDeleted, verificationResult.getAfter(), false); | ||
| return; | ||
| } | ||
| if (verifyType == IndexTool.IndexVerifyType.BOTH) { | ||
| verifyIndexRows(actualIndexMutationMap,expectedIndexMutationMap, Collections.EMPTY_SET, indexRowsToBeDeleted, verificationResult.getBefore(), true); | ||
| if (!expectedIndexMutationMap.isEmpty() || !indexRowsToBeDeleted.isEmpty()) { | ||
| repairIndexRows(expectedIndexMutationMap, indexRowsToBeDeleted, verificationResult); | ||
| } | ||
| @@ -215,6 +243,7 @@ private void repairAndOrVerifyIndexRows(Set<byte[]> dataRowKeys, | ||
| } | ||
| } | ||
| private void addRepairAndOrVerifyTask(TaskBatch<Boolean> tasks, | ||
| final Set<byte[]> dataRowKeys, | ||
| final Map<byte[], List<Mutation>> actualIndexMutationMap, | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.