Uh oh!
There was an error while loading. Please reload this page.
Fix bad_weak_ptr when close a ClientConnection during construction - #350
Merged
BewareMyPower merged 1 commit intoNov 17, 2023
Merged
Conversation
BewareMyPower
requested review from
Demogorgon314, RobertIndie, merlimat and shibdNovember 16, 2023 12:32
RobertIndie
requested changes
Nov 16, 2023
Uh oh!
There was an error while loading. Please reload this page.
BewareMyPowerforce-pushed
the
bewaremypower/fix-cnx-bad-weak-ptr
branch
2 times, most recently
from
November 17, 2023 08:08
01ea0b1 to
ba714eaCompareBewareMyPower
commented
Nov 17, 2023
ContributorAuthor
@RobertIndie I used an exception-based way to fix this issue now so |
BewareMyPower
marked this pull request as draft
November 17, 2023 08:11
BewareMyPower
commented
Nov 17, 2023
ContributorAuthor
The |
Fixesapache#348Fixesapache#349 ### Motivation When `close` is called in `ClientConnection`'s constructor, `shared_from_this()` will be called, which results in a `std::bad_weak_ptr` error. This error does not happen before apache#317 because `shared_from_this()` could only be called when the `producers` or `consumers` field is not empty. ### Modifications Throw `ResultAuthenticationError` when there is anything wrong with authentication in `ClientConnection`'s constructor. Then catch the result in `ConnectionPool::getConnectionAsync` and returned the failed future. In addition, check `authentication_` even for non-TLS URLs. Otherwise, the null authentication will be used to construct `CommandConnect`. Add `testInvalidPlugin` and `testTlsConfigError` to verify the changes.
BewareMyPowerforce-pushed
the
bewaremypower/fix-cnx-bad-weak-ptr
branch
from
November 17, 2023 08:48
688905d to
2a4e5b3CompareBewareMyPower
marked this pull request as ready for review
November 17, 2023 08:49
RobertIndie
approved these changes
Nov 17, 2023
BewareMyPower added a commit
that referenced
this pull request
Nov 17, 2023
) Fixes#348Fixes#349 ### Motivation When `close` is called in `ClientConnection`'s constructor, `shared_from_this()` will be called, which results in a `std::bad_weak_ptr` error. This error does not happen before #317 because `shared_from_this()` could only be called when the `producers` or `consumers` field is not empty. ### Modifications Throw `ResultAuthenticationError` when there is anything wrong with authentication in `ClientConnection`'s constructor. Then catch the result in `ConnectionPool::getConnectionAsync` and returned the failed future. In addition, check `authentication_` even for non-TLS URLs. Otherwise, the null authentication will be used to construct `CommandConnect`. Add `testInvalidPlugin` and `testTlsConfigError` to verify the changes. (cherry picked from commit 7bb94f4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#348
Fixes#349
Motivation
When
closeis called inClientConnection's constructor,shared_from_this()will be called, which results in astd::bad_weak_ptrerror. This error does not happen before#317 because
shared_from_this()could only be called when theproducersorconsumersfield is not empty.Modifications
Add a
ResultExceptionand throw it if there is a failure inClientConnection's constructor and catch it inConnectionPool::getConnectionAsync. Then retrieve the result andreturn the failed future.
Since
closeis now always called on a constructedClientConnectionobject, remove the 2nd parameter.
In addition, check
authentication_even for non-TLS URLs. Otherwise,the null authentication will be used to construct
CommandConnect.Add
testInvalidPluginandtestTlsConfigErrorto verify the changes.