Skip to content

[refactor] Modify the README to apply the new installation method - #239

Merged
BewareMyPower merged 4 commits into
apache:masterfrom
shibd:change_docs
Nov 27, 2022
Merged

[refactor] Modify the README to apply the new installation method#239
BewareMyPower merged 4 commits into
apache:masterfrom
shibd:change_docs

Conversation

@shibd

@shibdshibd commented Oct 31, 2022

Copy link
Copy Markdown
Member

Motivation

#235 and #238 support downloading prebuilt binary when npm install. This simplifies installation for users.

Modifications

  • Modify the README to apply the new install and build method.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd

shibd commented Oct 31, 2022

Copy link
Copy Markdown
MemberAuthor

@merlimat@massakam@AnonHxy Can you take a look? Thanks.

@shibdshibd mentioned this pull request Nov 2, 2022
Open
tisonkun
tisonkun reviewed Nov 2, 2022
View reviewed changes

@tisonkuntisonkun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this page! Comments inline.

Comment threadpkg/mac/common.sh Outdated
Comment threadpkg/mac/common.sh
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadREADME.md
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
@shibd
shibd requested a review from tisonkunNovember 2, 2022 03:45
merlimat
merlimat approved these changes Nov 5, 2022
View reviewed changes

@merlimatmerlimat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait to merge this until the new release is out

@BewareMyPower
BewareMyPower merged commit bba4303 into apache:masterNov 27, 2022
@shibdshibd mentioned this pull request Dec 3, 2022
Closed
@RobertIndieRobertIndie added this to the 1.8.0 milestone Dec 20, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimatmerlimatmerlimat approved these changes
@RobertIndieRobertIndieRobertIndie approved these changes
@tisonkuntisonkuntisonkun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@shibd@merlimat@RobertIndie@tisonkun@BewareMyPower