Uh oh!
There was an error while loading. Please reload this page.
Fix build MacOS x64 binary name error. - #249
Closed
shibd wants to merge 1 commit into
Closed
Conversation
BewareMyPower
approved these changes
Nov 25, 2022
RobertIndie
approved these changes
Nov 25, 2022
Uh oh!
There was an error while loading. Please reload this page.
4 tasks
shibd
commented
Nov 27, 2022
MemberAuthor
Close this, as #250 already contains it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In MacOS x64, We pre-order build binary filenames are: napi-darwin-unknown-
x86_64.tar.gzHowever, the arch obtained by Node is x64. This way, when the user executes
npm install, the binary file will not be found. Because it will go to request a download: napi-darwin-unknown-x64.tar.gzModifications
x64.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)