Uh oh!
There was an error while loading. Please reload this page.
Remove useless dependencies. - #258
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
shibd
commented
Dec 7, 2022
@BewareMyPower@RobertIndie@tisonkun I add |
BewareMyPower
left a comment
There was a problem hiding this comment.
Not sure whether should we add two lock files for both npm and yarn. When I ran yarn install in my local env, there was a warning:
$ yarn install --no-scripts
yarn install v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.After the yarn install command is done, the yarn.lock file changed a lot:
$ git diff yarn.lock | wc -l
7082shibd
commented
Dec 8, 2022
You are right. For developers, we should only use one way to manage dependencies. I remove BTW: For users, It can optionally use In this PR, we verified the installation method using yarn. |
Uh oh!
There was an error while loading. Please reload this page.
shibd
commented
Dec 12, 2022
RobertIndie
left a comment
There was a problem hiding this comment.
What's the motivation for removing package-lock.json?
shibd
commented
Dec 13, 2022
Not deleted. Only updated. |
Motivation
In #235, wrong introduction of
verbosedependencies. It will cause the installation to fail usingyarn install.Modifications
verbosedependence.node-pre-gyp-github, is also useless dependence. It is responsible for publishing NAPI to Release page. Refer Upload binaries napi to release. #245; We don't need to publish.yarnis available.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)