Uh oh!
There was an error while loading. Please reload this page.
RATIS-1614. Upgrade Ratis Thirdparty to 1.0.1 - #670
Merged
Conversation
…and remove the dependency
codings-dan
commented
Jul 5, 2022
ContributorAuthor
@szetszwo Could you help review this pull request, thank you! |
szetszwo
approved these changes
Jul 5, 2022
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
+1 the change looks good.
codings-dan
commented
Jul 6, 2022
ContributorAuthor
@szetszwo Thanks for helping review and merging the pull request! |
szetszwo
reviewed
Jul 6, 2022
Comment on lines
407
to
429
| <dependency> | ||
| <groupId>io.dropwizard.metrics</groupId> | ||
| <artifactId>metrics-core</artifactId> | ||
| <version>${dropwizard.version}</version> | ||
| <version>${shaded.dropwizard.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.dropwizard.metrics</groupId> | ||
| <artifactId>metrics-jvm</artifactId> | ||
| <version>${dropwizard.version}</version> | ||
| <version>${shaded.dropwizard.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.dropwizard.metrics</groupId> | ||
| <artifactId>metrics-jmx</artifactId> | ||
| <version>${dropwizard.version}</version> | ||
| <version>${shaded.dropwizard.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.dropwizard.metrics</groupId> | ||
| <artifactId>metrics-ganglia</artifactId> | ||
| <version>${dropwizard.ganglia.version}</version> | ||
| <version>${shaded.dropwizard.ganglia.version}</version> | ||
| </dependency> |
Contributor
There was a problem hiding this comment.
Oops, we should remove all the dropwizard dependencies and change all the imports to org.apache.ratis.thirdparty.com.codahale.metrics.*
@codings-dan , I have reopened RATIS-1601.
ContributorAuthor
szetszwo pushed a commit
that referenced
this pull request
Jul 14, 2022
symious pushed a commit
to symious/ratis
that referenced
this pull request
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade Ratis Thirdparty to 1.0.1, which has the following (non-test) changes:
RATIS-1585. Bump gson to 2.8.9
RATIS-1591. Bump netty to 4.1.77
RATIS-1595. Shade dropwizard 4.x in ratis-thirdparty
RATIS-1601. Use the shaded dropwizard metrics and remove the dependency
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1614
https://issues.apache.org/jira/browse/RATIS-1601
How was this patch tested?
https://github.com/codings-dan/incubator-ratis/actions/runs/2616031344