Uh oh!
There was an error while loading. Please reload this page.
SAMZA-2233: Allow overriding descriptor generated task.inputs using configs - #1065
Closed
prateekm wants to merge 4 commits into
Closed
SAMZA-2233: Allow overriding descriptor generated task.inputs using configs#1065prateekm wants to merge 4 commits into
prateekm wants to merge 4 commits into
Conversation
prateekm
commented
Jun 4, 2019
ContributorAuthor
@Sanil15 Can you please take a look for TestRunner changes. |
| "Specify them using InputDescriptors instead. Ignoring configured task.inputs value of " + | ||
| userConfig.get(TaskConfig.INPUT_STREAMS())); | ||
| // Don't allow overriding task.inputs to a blank string | ||
| if (StringUtils.isBlank(userConfig.get(TaskConfig.INPUT_STREAMS()))) { |
Contributor
There was a problem hiding this comment.
Why is this check required?
ContributorAuthor
There was a problem hiding this comment.
samza app-def sets task.inputs = "" by default, so we need to ignore that. It's a simple and useful enough check that I kept this in OSS instead of patching in LI.
Sanil15
approved these changes
Jun 5, 2019
Sanil15
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes, LGTM!
rmatharu-zz
approved these changes
Jun 5, 2019
prateekmforce-pushed
the
allow-task-inputs-override
branch
from
June 7, 2019 00:42
3271f68 to
ee0af24Comparecameronlee314
approved these changes
Jun 7, 2019
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.