chore(python/sedonadb,python/sedonadb-zarr): Update pyo3 to 0.29 - #1017
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Python extension crates (python/sedonadb and python/sedonadb-zarr) to use PyO3 0.29 via the workspace dependency, and adjusts the Rust bindings to match PyO3 API and macro changes introduced in the newer version.
Changes:
- Bump PyO3 to
0.29.0at the workspace level and switch Python crates topyo3 = { workspace = true }. - Update PyO3 interop code to newer APIs (e.g.,
PyCapsule::new_with_value,cast()/into_bound()), and adjust#[pyclass(...)]options. - Refresh
Cargo.lockto reflect the dependency upgrade.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| python/sedonadb/src/udf.rs | Updates PyO3 capsule creation and casting APIs; adjusts #[pyclass] options for UDF wrapper types. |
| python/sedonadb/src/schema.rs | Updates Arrow schema capsule creation and #[pyclass] options for schema/type wrappers. |
| python/sedonadb/src/raster_loader.rs | Updates PyO3 downcasting to cast() and adjusts #[pyclass] options/derives for raster loader types. |
| python/sedonadb/src/import_from.rs | Updates capsule creation and capsule validation to use pointer_checked. |
| python/sedonadb/src/expr.rs | Enables extraction from Python objects for internal expr wrapper types via from_py_object. |
| python/sedonadb/src/error.rs | Adds PyClassGuardError conversion to PySedonaError (but currently has a compile-signature issue). |
| python/sedonadb/src/datasource.rs | Marks PyExternalFormat as extractable from Python objects; updates capsule creation for Arrow stream. |
| python/sedonadb/src/dataframe.rs | Updates capsule creation for FFI table provider and Arrow streams; removes now-unneeded CString usage. |
| python/sedonadb/Cargo.toml | Switches PyO3 dependency to workspace-managed. |
| python/sedonadb-zarr/src/lib.rs | Updates Arrow stream capsule creation and #[pyclass] options for view entry type. |
| python/sedonadb-zarr/Cargo.toml | Switches PyO3 dependency to workspace-managed. |
| Cargo.toml | Adds workspace dependency pyo3 = { version = "0.29.0" }. |
| Cargo.lock | Updates locked dependency graph for PyO3 0.29.0 and transitive changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #1012 (which took care of the hard part of enabling free threading) and taking care of the harder upgrade...this updates to the latest version fixes compile errors in the process.
Closes #949.