Uh oh!
There was an error while loading. Please reload this page.
Fix bug log4j2 grpc report missing traceId - #181
Conversation
andotorg
commented
May 21, 2022
|
| * Enhance Apache ShenYu (incubating) plugin: support trace `grpc`,`sofarpc`,`motan`,`tars` rpc proxy. | ||
| * Add primary endpoint name to log events. | ||
| * Fix Span not finished in gateway plugin when the gateway request timeout. | ||
| * Fix discussions #9113, log4j2 grpc report missing traceId |
There was a problem hiding this comment.
I think we need some update on the docs https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/application-toolkit-log4j-2.x/
Please update application-toolkit-log4j-2.x.md accordingly.
There was a problem hiding this comment.
| *Fix discussions #9113, log4j2 grpc report missing traceId | |
| *Support `-Dlog4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector` in gRPC log report. |
There was a problem hiding this comment.
Notice #9113 is actually not working, because this is not in the same repository.
There was a problem hiding this comment.
Do I need to recreate an issues?
There was a problem hiding this comment.
No, I mean the link.#issue/discussion number is only working as a link when PR and issue are in the same repo. And we don't put this in the change log. The changelog is related to a commit/PR already.
| .setSpanId(ContextManager.getSpanId()) | ||
| .setTraceSegmentId(ContextManager.getSegmentId()) | ||
| .build()).build(); | ||
| // fix -Dlog4j2.contextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector not traceId |
There was a problem hiding this comment.
This comment seems not current. You should explain about AsyncLoggerContextSelector is working on async mode, so it has to use SkyWalkingContext.
Comments for fix xxx actually is pointless, because git log already includes this information.
wu-sheng
commented
May 22, 2022
CI fails, you seem not following code style? Please fix them and adjust them according to the review comments. |
andotorg
commented
May 22, 2022
OK, I'll revise it |
andotorg
commented
May 22, 2022
wu-sheng
commented
May 22, 2022
Why do you close this and open a new one? |
andotorg
commented
May 22, 2022
|
andotorg
commented
May 22, 2022
Resubmitted, modified according to the specification |
wu-sheng
commented
May 22, 2022
If you want to keep the commit log short, do This time is fine, next time, please keep in one pull request. |
andotorg
commented
May 22, 2022
ok, thanks |
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
Fix apache/skywalking#9113
[✅] Fix the problem that traceid cannot be reported when log4j2 global is modified to asynchronous log
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ====
[✅] Update the
CHANGESlog.